modtool: use prefix path for modtool instead of prefs #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a prefix gets installed, the [modtool] section in prefs hardcodes the path to the templates in the newly installed prefix as a global path for all modtools. This creates major problems when bouncing between prefixes, especially when newmod changes between releases Why not just use the prefix as the root of where to look for the templates
michaelld
approved these changes
Mar 19, 2020
|
Looks like it should be Py27 and Py3 compatible, too ... so, could be backported back to GR37! |
|
Could this technically be considered an api change though? |
hmmm ... I don't think so. All this change does is fix where to find the default source location for modtool (or something like that) ... yes? |
dkozel
approved these changes
Mar 28, 2020
mormj
added
Backport-3.8
|
two approvals ... merging. Will do backport PRs for this as well |
willcode
added
ported-to-3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up here for discussion - though I don't see the downsides to this change just yet.
When a prefix gets installed, the [modtool] section in prefs hardcodes
the path to the templates in the newly installed prefix as a global path
for all modtools. This creates major problems when bouncing between
prefixes, especially when newmod changes between releases
Why not just use the prefix as the root of where to look for the
templates
This potentially contributed to issues such as #2812 and #2873