New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grc: Fix crash when using function probe with BokehGUI #3301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small tweak, but otherwise LGTM
|
I tagged a few other GR devs to see what they think ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mormj you around to check out this PR? Should be quick ... |
|
I've actually never tried out the bokeh framework, so this one I'll have to give a try later |
|
@mormj ping ... any progress? I've ever tried the boken framework either ... but the code looks good & if the author says it does the trick I'm willing to go with that. |
|
Trying to get bokeh set up, but ran into this (among others): Also, gr-bokeh does not currently compile with master branch gr. Not sure the depth of changes needed |
|
I have not yet pulled the 3.8 port to the gnuradio gr-bokehgui repo. |
|
And now it's done. You should be able to build with maint-3.8. Master is not yet supported since the change in shared pointers. |
|
@mormj ... Any news on this part? It should even work on master (at least related to the shared pointer changes). |
|
I still haven't gotten gr-bokeh to work yet, but I pulled in this change and verified it didn't break the function probe, so I go ahead and merge. |
The function probe block creates a new worker thread to do it's thing, this means that the callback to update the value of the block is executed in that separate thread.
The bokeh framework doesn't allow that, so using a probe block value in a BokehGUI block causes a crash.
This PR solves it by giving the callback function to the bokeh framework so it can execute it in its own thread.
I did not know how to check whether QT or bokeh is active from the yaml file, so I made a nested try.
This can be backported to maint-3.8.