Prevent Windows CRLF conversion for files subject to pybind hash comparisons #4140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GNURadio 3.9, pybind11 compares hash values of headers and source files against knowns values. Conversion of values to CRLF on checkout break those checks so keep LF values when files are subject to said checks.
I only saw code doing hashing for C source and header files. Are there any other file types where this is used I didn't see?
Also, does these hash checks serve additional purposes after build that we need to be aware of?