Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Windows CRLF conversion for files subject to pybind hash comparisons #4140

Merged

Conversation

gnieboer
Copy link
Contributor

In GNURadio 3.9, pybind11 compares hash values of headers and source files against knowns values. Conversion of values to CRLF on checkout break those checks so keep LF values when files are subject to said checks.

I only saw code doing hashing for C source and header files. Are there any other file types where this is used I didn't see?
Also, does these hash checks serve additional purposes after build that we need to be aware of?

…arisons

Signed-off-by: gnieboer <gnieboer@corpcomm.net>
@gnieboer gnieboer force-pushed the gnieboer-disable-certain-CRLF-conversions branch from 169cb1a to 787a190 Compare January 23, 2021 16:32
@mbr0wn
Copy link
Member

mbr0wn commented Jan 24, 2021

I only saw code doing hashing for C source and header files. Are there any other file types where this is used I didn't see?

No, that's it. This is for matching the Pybind11 bindings with the original C++ source code.

Also, does these hash checks serve additional purposes after build that we need to be aware of?

Not that I know of.

@mbr0wn
Copy link
Member

mbr0wn commented Jan 25, 2021

For people's reference: https://www.git-scm.com/docs/gitattributes

  • text attribute: Setting the text attribute on a path enables end-of-line normalization and marks the path as a text file. End-of-line conversion takes place without guessing the content type.
  • eol attribute: Set to string value "lf": This setting forces Git to normalize line endings to LF on checkin and prevents conversion to CRLF when the file is checked out.

[copy & pasted from reference above]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants