runtime: logging performance improvement #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcode
force-pushed
the
log-performance
branch
from
1a553f8
to
a89cdc3
Compare
Based on email discussion with Boris Marjanovic. The logging macros always pass the "msg" param to the logger (currently log4cpp). In the macros, "msg" can be an expression and it will be evaluated, even if the log message would not be printed (based on log level). This commit adds checks to each macro to make sure the message will be logged. Since this check is also done internally to log4cpp, some duplication results, but it should be far less effort than evaluating an arbitrary "msg". Signed-off-by: Jeff Long <willcode4@gmail.com>
willcode
force-pushed
the
log-performance
branch
from
a89cdc3
to
770eefb
Compare
bmarjanovic
approved these changes
Aug 7, 2021
There was a problem hiding this comment.
The changes look good. The new macros have been working correctly for me.
A possible (separate from this) improvement to show assert message on command line (cerr). That would require additional macro - something like
#ifdef NDEBUG
# define assertm(exp, msg) ((void)(0))
#else
# define assertm(exp, msg) \
if (!exp) { \
std::cerr << "Assertion: " << msg; \
assert(exp); \
}
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on email discussion with Boris Marjanovic.
Logging is being overhauled on master branch, so this is being introduced directly to maint-3.9.
The logging macros always pass the "msg" param to the logger (currently
log4cpp). In the macros, "msg" can be an expression and it will be
evaluated, even if the log message would not be printed (based on log
level).
This commit adds checks to each macro to check whether the message will be
logged. Since this check is also done internally to log4cpp, some
duplication results, but it should be far less effort than evaluating
an arbitrary "msg".
Signed-off-by: Jeff Long willcode4@gmail.com