grc: A generated python hier_block is written to the wrong directory

[dl1ksv]

---

Pull Request Details

The generated code is written to the directory of the generating grc file
instead to the 'hier_block_lib_dir' directory.

cpp generated code ends up in the correct directory.

This error was introduced with commit af3fbe4

Description

Take the directory from the config settings ( as before)

Related Issue

Fixes #5531

Testing Done

Tested with different hier blocks

Checklist

• I have read the CONTRIBUTING document.
• I have squashed my commits to have one significant change per commit.
• I have signed my commits before making this PR
• My code follows the code style of this project. See GREP1.md.
• I have updated the documentation where necessary.
• I have added tests to cover my changes, and all previous tests pass.

[willcode]

Does this still work with grcc? #4871 makes it seem like this change was intended. Should the correct directory be passed in from above instead of ignored?

[dl1ksv]

Good point.

Without my patch
In case test.grc is a hier block with output langage python
grcc -o /tmp/test test.grc
is written to /tmp/test
but if the output language is c++ the code is written ~/.grc_gnuradio/
which is not intended.

After my patch in both cases the code is written ~/.grc_gnuradio.

All other combinations of generation option and output language are not affected by my patch.
To write hier block code to the specified output directory this should be fixed in grcc.
This is done by the commit 5114e51.

[mormj]

After my patch in both cases the code is written ~/.grc_gnuradio.

Shouldn't the output given grcc -o /tmp/test be to /tmp/test in both cases?

[dl1ksv]

Yes, but I wanted to point out, that this was not the case without any patch. After my first commit the code for the hier block is written to ~/.grc_gnuradio , independently of the the output language. For other types the code is written to the correct directory.
The second commit forces grcc -o /tmp/test to write to /tmp/test for hier blocks , too.

[mormj]

Ah ok - I didn't get the distinction between the two commits. Thanks!

[mormj]

Tested and working - sorry for the delay and thank you for the fix.