Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iio: Fix sink scalar value to match format le:S16/16. #6024

Merged
merged 1 commit into from Jul 26, 2022

Conversation

AlexandraTrifan
Copy link
Contributor

@AlexandraTrifan AlexandraTrifan commented Jul 25, 2022

Pull Request Details

Fix scalar value in fmcomms2 sink to match the IIO format le:S16/16>>0

Description

TX output power is aprox 25 dB lower (for the given example) when using ADALM Pluto with gnuradio 3.10 (compared to 3.8 results).
There is an error when converting data from float to int.
The data is scaled to 12 bits instead of 12 bits left shifted by 4 (16 bits where the 4 LSBs don't matter).
This caused the shifting of 4 most significant bits to the right, essentially losing 4 MSBs where most of the power is (about 90% power).

Related Issue

Reported and tested here: https://ez.analog.com/adieducation/university-program/f/q-a/560641/pluto-grc-3-10-sink-block-has-low-output-power .

Which blocks/areas does this affect?

The fmcomms2 sink, part of the gr-iio module.

Testing Done

Testing reported in the issue mentioned above.

Checklist

Signed-off-by: AlexandraTrifan <Alexandra.Trifan@analog.com>
@mormj mormj added Bug Fix iio Related to gr-iio module Backport-3.10 Should be backported to 3.10 labels Jul 25, 2022
@mormj mormj merged commit 831fb91 into gnuradio:main Jul 26, 2022
@willcode willcode added ported-to-3.10 Has been ported to 3.10 and removed Backport-3.10 Should be backported to 3.10 labels Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix iio Related to gr-iio module ported-to-3.10 Has been ported to 3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants