filter: Accept rounded output from fir_filter_fsf #6980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VOLK recently accepted gnuradio/volk#709, which fixes truncate-toward-zero distortion in
volk_32f_x2_dot_prod_16i. Unfortunately, this causes test failures:This is because the tests in question assert the truncate-toward-zero behaviour in
fir_filter_fsf. I would consider this behaviour buggy, and I would be surprised if there's any code that depends onfir_filter_fsfworking this way. So I propose to change the tests to assert rounded output, with a temporary fallback to truncated output which can be removed once GNU Radio requires VOLK >= 3.1.0.Which blocks/areas does this affect?
Testing Done
I verified that the updated tests pass before & after the VOLK change.
Checklist
I have updated the documentation where necessary.