pyqwt5: no longer attempting to install sip modules in /usr/share #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 4bf4e23 eliminated configure time dependency on the "reprefix" environment variable, but did so in such a way that sip modulues are installed under /usr/share instead of $PYBOMBS_PREFIX/share. This behavior is unintended and causes an error when pybombs is executed by a non-root user. This commit makes the following changes: * mirrors the "reprefix" fix applied to the qwt5 recipe in a38e3a5 * fixes whitespace and formatting jank introduced by the convert_1to2.py conversion * changed python module directory for sed and for installation from "python2.6" to "python2.7". This _should_ be safe since pybombs now requires python 2.7 to run
|
@estatz It seems that the value of |
|
This is the same issue as #20 where we need a version of the $prefix string with escape characters. I'm not entirely sure how sed was interpreting the non-escaped $prefix string, but the end result was that make install was attempting to install things in /usr/local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 4bf4e23 eliminated configure time dependency on the "reprefix"
environment variable, but did so in such a way that sip modulues are
installed under /usr/share instead of $PYBOMBS_PREFIX/share. This
behavior is unintended and causes an error when pybombs is executed
by a non-root user.
This commit makes the following changes:
convert_1to2.py conversion
from "python2.6" to "python2.7". This should be safe since
pybombs now requires python 2.7 to run
This resolves a CentOS 7 installation issue