Add deprecations for untested kernels #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have six kernels: - `volk_16i_x5_add_quad_16i_x4` - `volk_16i_branch_4_state_8` - `volk_16i_max_star_16i` - `volk_16i_max_star_horizontal_16i` - `volk_16i_permute_and_scalar_add` - `volk_16i_x4_quad_max_star_16i` that we don't test. They should be marked deprecated. If nobody complains, we can remove them in a future VOLK version. Otherwise, we need proper tests for those kernels because they are currently untested. Signed-off-by: Johannes Demel <demel@uni-bremen.de>
We assume that MSVC is the compiler on Windows and thus, we don't add deprecation warnings. Other platforms receive these warnings though. Signed-off-by: Johannes Demel <demel@uni-bremen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have six kernels:
volk_16i_x5_add_quad_16i_x4volk_16i_branch_4_state_8volk_16i_max_star_16ivolk_16i_max_star_horizontal_16ivolk_16i_permute_and_scalar_addvolk_16i_x4_quad_max_star_16ithat we don't test. They should be marked deprecated. If nobody complains, we can remove them in a future VOLK version. Otherwise, we need proper tests for those kernels because they are currently untested.
We assume that MSVC is the compiler on Windows and thus, we don't add deprecation warnings. Other platforms receive these warnings though. Ideas on how to improve these warnings are appreciated.
Fix #549