Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing mechanism needs step up #160

Closed
jeevatkm opened this issue Apr 7, 2018 · 9 comments
Closed

Routing mechanism needs step up #160

jeevatkm opened this issue Apr 7, 2018 · 9 comments
Assignees
Projects

Comments

@jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Apr 7, 2018

This is all started with this issue #159 created by @vzool. Currently aah routing supports Radix Tree (aka BTree) algorithm.

Based on scenario he brought up also making aah much more flexible and robust. It needs step up in current routing mechanism.

aah users can look forward to improved routing mechanism with features on v0.12.0 release.

  • Implementation
  • Documentation
@jeevatkm jeevatkm added this to the v0.12.0 Milestone milestone Apr 7, 2018
@jeevatkm jeevatkm self-assigned this Apr 7, 2018
@vzool vzool mentioned this issue Jul 15, 2018
@jeevatkm jeevatkm added this to v0.12.0 - Iteration in aah Roadmap via automation Jul 23, 2018
@jeevatkm jeevatkm moved this from v0.12.0 - Iteration to v0.12.0 - In Progress in aah Roadmap Aug 3, 2018
@jeevatkm
Copy link
Member Author

@jeevatkm jeevatkm commented Aug 3, 2018

@vzool I have started working on new router tree. once its completes I need your help on extensive testing. Thanks.

@jeevatkm
Copy link
Member Author

@jeevatkm jeevatkm commented Aug 13, 2018

@vzool I have almost done with new router tree implementation. Its ready for testing.

Please follow the below steps to try new router and share your feedback.

  • Go to $GOPATH/src/aahframework.org/router.v0
  • Do git pull --all && git checkout new-tree

Now as usual you could proceed with your development actvities.

Pending/Progress things on my end -

  • Already doing regression testing
  • cleanup and streamline signatures and godoc (internal to library)
  • I might add regex parameter feature if timeline permits otherwise I will move that enhancement to next release
  • Any bug fix from your discovery/testing

FYI, I didn't not use bone router you have referred. It turns out that library did not use tree implementation. It just does loop and does route match.

@jeevatkm
Copy link
Member Author

@jeevatkm jeevatkm commented Aug 15, 2018

@vzool ping 😄

@vzool
Copy link

@vzool vzool commented Aug 16, 2018

@jeevatkm pong

@jeevatkm
Copy link
Member Author

@jeevatkm jeevatkm commented Aug 16, 2018

@vzool Did you get a chance to try it out?

jeevatkm added a commit to go-aah/ws that referenced this issue Aug 18, 2018
jeevatkm added a commit that referenced this issue Aug 18, 2018
jeevatkm added a commit to go-aah/docs that referenced this issue Sep 2, 2018
@jeevatkm jeevatkm closed this Sep 2, 2018
aah Roadmap automation moved this from v0.12.0 - In Progress to v0.12.0 - Completed Sep 2, 2018
jeevatkm added a commit that referenced this issue Sep 17, 2018
jeevatkm added a commit that referenced this issue Sep 21, 2018
@jeevatkm jeevatkm moved this from v0.12.0 - Completed to Released to Audience in aah Roadmap Dec 4, 2018
@AugustHell
Copy link

@AugustHell AugustHell commented Dec 12, 2018

@jeevatkm
Copy link
Member Author

@jeevatkm jeevatkm commented Dec 12, 2018

@AugustHell Thank you for reporting it. I will have a look.

@jeevatkm
Copy link
Member Author

@jeevatkm jeevatkm commented Dec 12, 2018

@AugustHell Now documentation is available, thanks again.

@AugustHell
Copy link

@AugustHell AugustHell commented Dec 13, 2018

Thank you for strenuous efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
aah Roadmap
  
Released to Audience
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.