Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing mechanism needs step up #160

Closed
2 tasks done
jeevatkm opened this issue Apr 7, 2018 · 9 comments
Closed
2 tasks done

Routing mechanism needs step up #160

jeevatkm opened this issue Apr 7, 2018 · 9 comments
Assignees
Labels

Comments

@jeevatkm
Copy link
Member

jeevatkm commented Apr 7, 2018

This is all started with this issue #159 created by @vzool. Currently aah routing supports Radix Tree (aka BTree) algorithm.

Based on scenario he brought up also making aah much more flexible and robust. It needs step up in current routing mechanism.

aah users can look forward to improved routing mechanism with features on v0.12.0 release.

  • Implementation
  • Documentation
@jeevatkm
Copy link
Member Author

jeevatkm commented Aug 3, 2018

@vzool I have started working on new router tree. once its completes I need your help on extensive testing. Thanks.

@jeevatkm
Copy link
Member Author

@vzool I have almost done with new router tree implementation. Its ready for testing.

Please follow the below steps to try new router and share your feedback.

  • Go to $GOPATH/src/aahframework.org/router.v0
  • Do git pull --all && git checkout new-tree

Now as usual you could proceed with your development actvities.

Pending/Progress things on my end -

  • Already doing regression testing
  • cleanup and streamline signatures and godoc (internal to library)
  • I might add regex parameter feature if timeline permits otherwise I will move that enhancement to next release
  • Any bug fix from your discovery/testing

FYI, I didn't not use bone router you have referred. It turns out that library did not use tree implementation. It just does loop and does route match.

@jeevatkm
Copy link
Member Author

@vzool ping 😄

@vzool
Copy link

vzool commented Aug 16, 2018

@jeevatkm pong

@jeevatkm
Copy link
Member Author

@vzool Did you get a chance to try it out?

@AugustHell
Copy link

Routing documentation along with some other topics is not available atm.
All of these links show a Not Found error:
(same for previous versions)
https://docs.aahframework.org/v0.12/routing.html
https://docs.aahframework.org/v0.12/routes-config.html
https://docs.aahframework.org/v0.12/request-parameters-auto-bind.html
https://docs.aahframework.org/v0.12/request-and-response.html

@jeevatkm
Copy link
Member Author

@AugustHell Thank you for reporting it. I will have a look.

@jeevatkm
Copy link
Member Author

@AugustHell Now documentation is available, thanks again.

@AugustHell
Copy link

Thank you for strenuous efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants