Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hassle of domain mapping on non-dev profile if its only one domain is used #163

Closed
jeevatkm opened this issue Apr 8, 2018 · 1 comment
Assignees
Projects

Comments

@jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Apr 8, 2018

Goal is to remove the hassle of domain mapping on non-dev profile if its only one domain is used or configured.

I'm adding this enhancement due to this question on Gitter https://gitter.im/aahframework/community?at=5ac4b47b5f188ccc152c4a1a (assuming he was trying with one domain)

What does it mean?
As you know, aah natively supports multi domain and subdomain implementation. Basically it does routing based on incoming request host & port no. So it requires to provide information about host & port no is being used on non-dev profile.

For e.g.: Following is aahframework.org and docs.aahframework.org domain mappings on prod profile.

routes {
  domains {
    aahframework {
      host = "aahframework.org"
      port = "443"
    }

    docs_aahframework {
      host = "docs.aahframework.org"
      port = "443"
    }
  }
}

Outcome of this Enhancement
If its only one domain is used or configured. aah router recognizes and will treats it as *. So aah users are not required to provide above domain mapping 😄

@jeevatkm jeevatkm added this to the v0.11.0 Milestone milestone Apr 8, 2018
@jeevatkm jeevatkm self-assigned this Apr 8, 2018
@jeevatkm jeevatkm added this to v0.11.0 - Iteration in aah Roadmap via automation Apr 8, 2018
@jeevatkm jeevatkm moved this from v0.11.0 - Iteration to v0.11.0 - In Progress in aah Roadmap Apr 12, 2018
jeevatkm added a commit to go-aah/router that referenced this issue Apr 12, 2018
… its only one domain configured
@jeevatkm

This comment has been minimized.

Copy link
Member Author

@jeevatkm jeevatkm commented Apr 12, 2018

Its done on edge 😄

@jeevatkm jeevatkm closed this Apr 12, 2018
aah Roadmap automation moved this from v0.11.0 - In Progress to v0.11.0 - Completed Apr 12, 2018
@jeevatkm jeevatkm moved this from v0.11.0 - Completed to Released to Audience in aah Roadmap Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
aah Roadmap
  
Released to Audience
1 participant
You can’t perform that action at this time.