Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console commands #198

Closed
radutopala opened this Issue Jul 15, 2018 · 8 comments

Comments

3 participants
@radutopala
Copy link

commented Jul 15, 2018

We should be able to run commands directly from the main binary if in prod env or through aah binary when in dev mode.

Please see Buffalo grifts at https://github.com/markbates/grift, https://github.com/gobuffalo/buffalo/tree/master/grifts.


  • Implement console module
  • Update aah CLI to use new console module
  • Adapt new console module for aah application binary (startup, version, etc)
  • Documentation
@jeevatkm

This comment has been minimized.

Copy link
Member

commented Jul 15, 2018

@radutopala I like the idea. Could you provide further details on commands that would be a candidate to be run from app/main binary?

I could think of one action is database migrate from app library.

@radutopala

This comment has been minimized.

Copy link
Author

commented Jul 15, 2018

@jeevatkm I'd see this as a generic gate for any kind of commands that a developer needs to create in his app, similar to what Symfony has done with the Console component Or Buffalo with Grifts.

So, basically, we should be allowed:

  • to create N number of commands
  • attach them to the main binary in prod or run them through aah in dev; in dev, commands should be parsed on-the-fly, let's say from the root/command folder; in prod, commands should be embedded in VFS

Examples can be numerous: db migration command, one-off commands, import commands, app specific setup commands etc

@jeevatkm

This comment has been minimized.

Copy link
Member

commented Jul 15, 2018

@radutopala Now I fully understood. Thanks. So console module it is 😄

@jeevatkm jeevatkm self-assigned this Jul 15, 2018

@radutopala radutopala changed the title Built-in commands Console commands Jul 15, 2018

@radutopala

This comment has been minimized.

Copy link
Author

commented Jul 15, 2018

@jeevatkm I've renamed the issue to be in line with the spec 😄

@jeevatkm jeevatkm added this to the v0.12.0 Milestone milestone Sep 7, 2018

@jeevatkm jeevatkm added this to v0.12.0 - Iteration in aah Roadmap via automation Sep 7, 2018

@jeevatkm jeevatkm moved this from v0.12.0 - Iteration to v0.12.0 - In Progress in aah Roadmap Oct 18, 2018

jeevatkm added a commit that referenced this issue Oct 18, 2018

jeevatkm added a commit to go-aah/tools that referenced this issue Oct 18, 2018

jeevatkm added a commit that referenced this issue Oct 28, 2018

jeevatkm added a commit to go-aah/tools that referenced this issue Oct 28, 2018

go-aah/aah#198 go-aah/aah#199 integrated new console module into run …
…and build flow and moved generated file into directory generated

jeevatkm added a commit that referenced this issue Nov 2, 2018

jeevatkm added a commit that referenced this issue Nov 2, 2018

jeevatkm added a commit that referenced this issue Nov 2, 2018

jeevatkm added a commit to go-aah/tools that referenced this issue Nov 2, 2018

jeevatkm added a commit to go-aah/tools that referenced this issue Nov 2, 2018

go-aah/aah#198, go-aah/aah#199 integrated new console module into run…
… and build flow and moved generated file into directory generated

jeevatkm added a commit that referenced this issue Nov 14, 2018

jeevatkm added a commit that referenced this issue Nov 15, 2018

@vzool

This comment has been minimized.

Copy link

commented Nov 15, 2018

This even could behave like a background Tasks/Jobs run by cron 😍

jeevatkm added a commit to go-aah/docs that referenced this issue Nov 16, 2018

jeevatkm added a commit that referenced this issue Nov 16, 2018

jeevatkm added a commit to go-aah/docs that referenced this issue Nov 17, 2018

jeevatkm added a commit to go-aah/tools that referenced this issue Nov 17, 2018

@jeevatkm

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

@radutopala Here is the upcoming console commands documentation https://github.com/go-aah/docs/blob/v0.12-edge/console-commands.md

Could you have a look and let me know if you have questions?

@jeevatkm

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

Done 😄

@jeevatkm jeevatkm closed this Nov 17, 2018

aah Roadmap automation moved this from v0.12.0 - In Progress to v0.12.0 - Completed Nov 17, 2018

@radutopala

This comment has been minimized.

Copy link
Author

commented Nov 17, 2018

@jeevatkm top notch, thx

@jeevatkm jeevatkm moved this from v0.12.0 - Completed to Released to Audience in aah Roadmap Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.