Skip to content

/ aah

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move auto-generated files to a cache folder #199

Closed
radutopala opened this issue Jul 15, 2018 · 3 comments
Closed

Move auto-generated files to a cache folder #199

radutopala opened this issue Jul 15, 2018 · 3 comments
Assignees
@jeevatkm
Labels
cli-tool enhancement
Projects
aah Roadmap
Milestone
v0.12.0 Milestone

Comments

@radutopala
Copy link

@radutopala radutopala commented Jul 15, 2018

Store the auto-generated root/app/aah.go and root/app/aah_app_vfs.go maybe in root/app/cache/ or root/cache, just to be clear for the developer that these files shouldn't be editable and that they are auto-generated on each run or build.
@jeevatkm

This comment has been minimized.

Sign in to view
Copy link
Member

@jeevatkm jeevatkm commented Jul 15, 2018

@radutopala Agreed. Its good to differentiate auto-generated files.

I believe directory root/app/cache would be appropriate, since directory app is meant for Go source files.
@jeevatkm jeevatkm self-assigned this Jul 15, 2018
@jeevatkm jeevatkm added the cli-tool label Jul 15, 2018
@jeevatkm jeevatkm added this to the v0.12.0 Milestone milestone Jul 15, 2018
@jeevatkm jeevatkm added this to v0.12.0 - Iteration in aah Roadmap via automation Jul 15, 2018
@jeevatkm jeevatkm moved this from v0.12.0 - Iteration to v0.12.0 - In Progress in aah Roadmap Oct 28, 2018
@jeevatkm

This comment has been minimized.

Sign in to view
Copy link
Member

@jeevatkm jeevatkm commented Oct 28, 2018

Going with directory name as generated at <app-base-directory>/app/generated. Since v0.12.0 release bring new module cache. Just on safer side and not to introduced confusion.

It will be imported on main file. Example -

 _ "<app-import-path>/app/generated"

This directory gets cleaned on every run, compile and build.
jeevatkm added a commit to go-aah/tools that referenced this issue Oct 28, 2018
@jeevatkm
go-aah/aah#198 go-aah/aah#199 integrated new console module into run …
9d9dcf1 
…and build flow and moved generated file into directory generated
@jeevatkm

This comment has been minimized.

Sign in to view
Copy link
Member

@jeevatkm jeevatkm commented Oct 28, 2018

Done 😄
@jeevatkm jeevatkm closed this Oct 28, 2018
aah Roadmap automation moved this from v0.12.0 - In Progress to v0.12.0 - Completed Oct 28, 2018
jeevatkm added a commit to go-aah/tools that referenced this issue Nov 2, 2018
@jeevatkm
go-aah/aah#198, go-aah/aah#199 integrated new console module into run…
Verified
This commit was signed with a verified signature.
jeevatkm Jeevanandam M.
GPG key ID: 15B44CCA54B0059C Learn about signing commits
865e513 
… and build flow and moved generated file into directory generated
@jeevatkm jeevatkm moved this from v0.12.0 - Completed to Released to Audience in aah Roadmap Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
cli-tool enhancement
Projects
aah Roadmap
  
Released to Audience
Milestone
  v0.12.0 Milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@radutopala @jeevatkm
You can’t perform that action at this time.