Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt-in catch all route support in the router #212

Closed
jeevatkm opened this issue Aug 20, 2018 · 1 comment
Closed

Add opt-in catch all route support in the router #212

jeevatkm opened this issue Aug 20, 2018 · 1 comment
Assignees
Projects

Comments

@jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Aug 20, 2018

The goal is to add opt-in catch all route support in the router per domain.

  • One catch all route per domain is allowed.
  • Catch all is opt-in feature, disabled by default.
  • If Catch all is not defined, existing flow applies i.e. 404 route not found
  • Implementation

    • aah user have to define section catch_all { ... } at domain level config in routes.conf
    • All the route configuration attributes are supported. If path and method value provided in the catch-all section then its ignored, since that value is defaults to *
  • Documentation

@jeevatkm jeevatkm added this to the v0.12.0 Milestone milestone Aug 20, 2018
@jeevatkm jeevatkm self-assigned this Aug 20, 2018
@jeevatkm jeevatkm added this to v0.12.0 - In Progress in aah Roadmap Aug 21, 2018
jeevatkm added a commit that referenced this issue Aug 22, 2018
jeevatkm added a commit to go-aah/docs that referenced this issue Sep 2, 2018
jeevatkm added a commit that referenced this issue Sep 2, 2018
@jeevatkm
Copy link
Member Author

@jeevatkm jeevatkm commented Sep 2, 2018

Done

@jeevatkm jeevatkm closed this Sep 2, 2018
aah Roadmap automation moved this from v0.12.0 - In Progress to v0.12.0 - Completed Sep 2, 2018
@jeevatkm jeevatkm moved this from v0.12.0 - Completed to Released to Audience in aah Roadmap Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
aah Roadmap
  
Released to Audience
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.