New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude subfolders on building single #245

Open
radutopala opened this Issue Jan 18, 2019 · 4 comments

Comments

2 participants
@radutopala
Copy link

radutopala commented Jan 18, 2019

We need to be able to exclude subfolders on build --single.

Right now, if specified like this: "./ui/public/*", "./ui/src/*", "./ui/test/*", they will still appear in vfs find.

@jeevatkm jeevatkm added this to v0.13.0 - Iteration in aah Roadmap via automation Jan 18, 2019

@jeevatkm jeevatkm added this to the v0.13.0 Milestone milestone Jan 18, 2019

@jeevatkm

This comment has been minimized.

Copy link
Member

jeevatkm commented Feb 19, 2019

@radutopala I would like to understand directory structure for the project. Could you share some tree structure view?

PS: If you would like to share via slack DM is also okay for confidentiality, I would like to learn some sample tree if possible

@jeevatkm

This comment has been minimized.

Copy link
Member

jeevatkm commented Feb 19, 2019

@radutopala Just to give you an insight into current implementation.

aah CLI takes file base name from walk func and does the filepath.Match call for excludes. That's why your above definition didn't work.

@radutopala

This comment has been minimized.

Copy link
Author

radutopala commented Feb 19, 2019

@jeevatkm well, I did a workaround for now and I wasn't required to have this deep subfolders exclusion after all.
But it would be nice to have this feature in the framework itself, to be able to exclude subfolders like "<root>/ui/tests" OR full file paths "<root>/ui/config/conf.dist".

@jeevatkm

This comment has been minimized.

Copy link
Member

jeevatkm commented Feb 19, 2019

@radutopala Thanks for your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment