Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#266 addressing path traversal issue on static file delivery #267

Merged
merged 1 commit into from Mar 3, 2020

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Mar 3, 2020

Closes #266

@jeevatkm jeevatkm added bug lib-static Static File delivery labels Mar 3, 2020
@jeevatkm jeevatkm self-assigned this Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #267 into master will decrease coverage by 0.46%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #267      +/-   ##
=========================================
- Coverage   85.36%   84.9%   -0.47%     
=========================================
  Files          94      94              
  Lines        7694    7696       +2     
=========================================
- Hits         6568    6534      -34     
- Misses        784     824      +40     
+ Partials      342     338       -4
Impacted Files Coverage Δ
static.go 52.45% <0%> (-23.58%) ⬇️
http_engine.go 80.2% <100%> (+0.1%) ⬆️
router.go 69.34% <0%> (-5.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcfe2c...2c8f53f. Read the comment docs.

@jeevatkm jeevatkm merged commit 881dc9f into master Mar 3, 2020
@jeevatkm jeevatkm deleted the static-delivery-fix branch March 3, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lib-static Static File delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant