Add DNS provider for VK Cloud #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, in order for a PR adding a DNS provider to be accepted, you have to:
make test
make test
make generate-dns
rm -rf .lego
./lego -m your@email.com --dns YOUR_PROVIDER_NAME -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory runNote the wildcard domain is important.
make checks
|
5 tasks
|
As I changed the code, I will ask you to run again the command: rm -rf .lego
./lego -m your@email.com --dns YOUR_PROVIDER_NAME -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run |
ok, i will make it today |
|
Unfortunately it stopped working, VK Cloud has not good API which works strange with trailing slash in URL, it required for each request except txt record deletion, i will fix it soon. Unfortunately i must replace path.Join call with fmt.Sprintf because path.Join clears trailing slash |
|
I fixed a bug with trailing slash, merged actual changes from master and now it works |
This reverts commit 6015678.
|
I implemented a simpler solution. the only case that can be a problem is on the delete. Note: your solution had a problem: package internal
import (
"fmt"
"strings"
"testing"
)
func TestName(t *testing.T) {
fmt.Println(joinURL("v2", "dns", "uri", "/")) // => "v2/dns/uri//" (double trailing slash)
}
func joinURL(parts ...string) string {
return strings.Join(parts, "/")
} |
|
I rethought the problem again and mimicked the go1.19 API. |
Great solution, shall i test it again? PS. I going to push trailing slash problem into DNS API team, hope they can fix it fast |
It's the same code as previously so I think you don't need to test it again.
I will merge now unless you think that we have to wait for your DNS API team. |
It's not, something went wrong) I will check and fix it
I think you can merge it after fix and not wait for DNS API team, when they fix api i will open new pull request with updates |
|
Now it works, problem was in BaseURL parsing, the scheme and domain were lost during the second Parse call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS Provider for VK Cloud. Closes #1705
./lego -m your@email.com --dns YOUR_PROVIDER_NAME ....go mod tidyStdout of example