Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
A surface level comparison of:
mitchellh/goamz/s3 doesn't have
crowdmob/goamz/s3 has added some of the same methods as mitchellh/goamz/s3
and others, but with a different method signature:
it has also changed some of the amz.v1 methods to take an Options struct:
and then added a whole slough of new methods, some that sound like they accomplish the same things as mitchellh/goamz/s3, but in a different way:
goamz/goamz/s3 looks pretty similar to crowdmob/goamz/s3.
This isn't to say all these methods should be added. But it does mean I can't take even a trivial project that was using mitchellh/goamz/s3 and recompile it with amz.v1/s3. Handy methods like GetBucketContents and MultiDel don't exist.
As another point of comparison, there is Stripe's generated API:
Note: I can't currently refer to http://godoc.org/gopkg.in/amz.v2-dev/s3 for comparison.
@matrixik, @nathany Hey guys, I had a chat with @niemeyer about those and other related issues. I'll send more details later today. There will be a CONTRIBUTING.md file with guidelines, and basically everyone who's familiar with both EC2/AWS and goamz/Go and wants to help and cares about the project can (and should) be a maintainer. Initially, the maintainers will be myself, @axw, @rogpeppe, @bz2, @katco-, and @wallyworld. More later, as I have to do a write-up.
Thanks for adding the CONTRIBUTING and getting the unstable branch setup.
For existing packages like this, I'm not sure if it makes sense to try to maintain the commits and who did them when bringing over methods. It would be nice, but seems like a lot of effort.
Instead it may make sense just to bring over missing functionality with the same method signatures -- or different if the API can be improved upon.
What are your thoughts?