Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added missing regions for Frankfurt and US Gov. #34
Conversation
|
Yes, please fix the China IAM URL. It does appear wrong. |
axw
reviewed
Mar 5, 2015
| + // TODO (anastasiamac 2015-03-05) should this not be | ||
| + // https://iam.cn-north-1.amazonaws.com.cn | ||
| + // ?? | ||
| + // I am looking at http://docs.aws.amazon.com/general/latest/gr/isolated_regions.html |
axw
Mar 5, 2015
Member
They both resolve to the same IP, but we should probably use the FQDN specified in the docs.
|
LGTM. |
added a commit
that referenced
this pull request
Mar 5, 2015
wallyworld
merged commit d448c15
into
go-amz:v3
Mar 5, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
anastasiamac
deleted the
anastasiamac:region-align
branch
Mar 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedMar 5, 2015
As part of response to Bug https://bugs.launchpad.net/juju-core/+bug/1427840, we have discovered that we are missing some regions.
Bug https://bugs.launchpad.net/juju-core/+bug/1428117 was created to deal with Frankfurt (eu-central-1) region specifically. However, there was also an isolated US Gov region missing.
Also, I am not convinced that Region for China has the correct iam url. Could someone with more knowledge in the area double check it?