/amz

Signing fixes & error handling. #47

Merged
merged 1 commit into from Apr 3, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kat-co @bz2
@kat-co
Member

kat-co commented Apr 3, 2015

  • EC2 queries now properly return errors from the signing process should they occur.
  • The v4 signing process now uses a "/" for the request path if no path is present.
  • Added test for describe-account-attributes, which was failing with v4 signing.

Live S3 testing done to ensure no breakages.
@kat-co
Signing fixes & error handling. 
- EC2 queries now properly return errors from the signing process should they occur.
- The v4 signing process now uses a "/" for the request path if no path is present.
- Added test for describe-account-attributes, which was failing with v4 signing.
0468977
@bz2
Member

bz2 commented Apr 3, 2015

LGTM.

As discussed on IRC, I'd like to change some more things about how we do the signing process, and make it robust to bad paths, but that's not something we need right now to fix the bug.

kat-co added a commit that referenced this pull request Apr 3, 2015

@kat-co
Merge pull request #47 from kat-co/ec2-ops-w-v4-signing 
Signing fixes & error handling.
f5c958d

@kat-co kat-co merged commit f5c958d into go-amz:v3 Apr 3, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment