ec2: add Instance.RootDevice{Type,Name} #57

Merged
merged 1 commit into from Jul 27, 2015

Conversation

Projects
None yet
2 participants
Member

axw commented Jul 24, 2015

Add the titular fields, as well as an optional
mode for the ec2test server which causes it to
create root disks for instances. We don't do
this by default because the automatically added
volumes can make tests unclear.

ec2: add Instance.RootDevice{Type,Name}
Add the titular fields, as well as an optional
mode for the ec2test server which causes it to
create root disks for instances. We don't do
this by default because the automatically added
volumes can make tests unclear.

axw added a commit to axw/juju that referenced this pull request Jul 24, 2015

provider/ec2: tag EBS root disks
When an instance is created, check if
it has an EBS root disk and, if so,
tag it.

Requires go-amz/amz#57

Fixes https://bugs.launchpad.net/juju-core/+bug/1476895

@axw axw referenced this pull request in juju/juju Jul 24, 2015

Merged

provider/ec2: tag EBS root disks #2879

Member

dimitern commented Jul 27, 2015

LGTM

axw added a commit that referenced this pull request Jul 27, 2015

Merge pull request #57 from axw/ec2-instance-rootdevice
ec2: add Instance.RootDevice{Type,Name}

@axw axw merged commit a771f4d into go-amz:v3 Jul 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

axw added a commit to axw/juju that referenced this pull request Jul 28, 2015

provider/ec2: tag EBS root disks
When an instance is created, check if
it has an EBS root disk and, if so,
tag it.

Requires go-amz/amz#57

Fixes https://bugs.launchpad.net/juju-core/+bug/1476895

axw added a commit to axw/juju that referenced this pull request Jul 28, 2015

provider/ec2: tag EBS root disks
When an instance is created, check if
it has an EBS root disk and, if so,
tag it.

Requires go-amz/amz#57

Fixes https://bugs.launchpad.net/juju-core/+bug/1476895

jujubot added a commit to juju/juju that referenced this pull request Jul 28, 2015

Merge pull request #2879 from axw/lp1476895-ec2-tag-root-disk
provider/ec2: tag EBS root disks

When an instance is created, check if
it has an EBS root disk and, if so,
tag it.

Requires go-amz/amz#57

Fixes https://bugs.launchpad.net/juju-core/+bug/1476895

(Review request: http://reviews.vapour.ws/r/2258/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment