Add tag support to instances #66

Merged
merged 2 commits into from Feb 24, 2016

Conversation

Projects
None yet
3 participants

goamz supports filtering by tag by adding a filter with a key
prefixed by "tag." I added this behavior to the current
instance implementation in ec2test.

Add tag support to instances
goamz supports filtering by tag by adding a filter with a key
prefixed by "tag." I added this behavior to the current
instance implementation in ec2test.
Member

axw commented Feb 22, 2016

According to http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html, the format is "tag:key", not "tag.key". Your Juju PR will need to be changed too. How did it work? Does AWS accept both? Either way, please use the documented format.

It accepts both apparently but I'll go with the documented one

On Sunday, 21 February 2016, Andrew Wilkins notifications@github.com
wrote:

According to
http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html,
the format is "tag:key", not "tag.key". Your Juju PR will need to be
changed too. How did it work? Does AWS accept both? Either way, please use
the documented format.


Reply to this email directly or view it on GitHub
#66 (comment).

Member

axw commented Feb 23, 2016

LGTM

dimitern pushed a commit that referenced this pull request Feb 24, 2016

@dimitern dimitern merged commit 345e929 into go-amz:v3 Feb 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment