Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add tag support to instances #66
Conversation
|
According to http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html, the format is "tag:key", not "tag.key". Your Juju PR will need to be changed too. How did it work? Does AWS accept both? Either way, please use the documented format. |
perrito666
commented
Feb 22, 2016
|
It accepts both apparently but I'll go with the documented one On Sunday, 21 February 2016, Andrew Wilkins notifications@github.com
|
|
LGTM |
perrito666 commentedFeb 19, 2016
goamz supports filtering by tag by adding a filter with a key
prefixed by "tag." I added this behavior to the current
instance implementation in ec2test.