This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Add tag support to instances #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goamz supports filtering by tag by adding a filter with a key prefixed by "tag." I added this behavior to the current instance implementation in ec2test.
|
According to http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html, the format is "tag:key", not "tag.key". Your Juju PR will need to be changed too. How did it work? Does AWS accept both? Either way, please use the documented format. |
|
It accepts both apparently but I'll go with the documented one On Sunday, 21 February 2016, Andrew Wilkins notifications@github.com
|
|
LGTM |
dimitern
pushed a commit
that referenced
this pull request
Feb 24, 2016
…instances Add tag support to instances
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goamz supports filtering by tag by adding a filter with a key
prefixed by "tag." I added this behavior to the current
instance implementation in ec2test.