/check

Added an interface for the reporter #76

Open
wants to merge 7 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elopio @fgimenez
@elopio
Contributor

elopio commented Jan 29, 2016

No description provided.

@elopio
Contributor

elopio commented Jan 29, 2016

In order to define a clean interface we first need to clean some things.
The suiteRunner gets the stream flag from the outputWriter. That's fixed in #71.
The Stream and Verbose flags are two different levels of the same thing. Fixed in #72.
The logger is handling part of the output. That's fixed in #75.
Finally, this PR defines the testReporter interface.

@elopio elopio referenced this pull request Jan 29, 2016

Closed

Join the Stream and Verbose flags into the verbosity value #73

fgimenez and others added some commits May 26, 2016

@fgimenez
update imports; make unit tests pass; add travis config
0e15685
@fgimenez
removed unused go packages
93eb158
@elopio
Merge pull request #6 from fgimenez/unit-tests 
update imports; make unit tests pass; add travis config
4dc4e50
@elopio
Copy the Stream config to the suiteRunner (#2) 
If the runner needs the Stream value from the config, it should not get
it from the reporter. It is better to keep a copy of the value in the
runner itself to make the communication between runner and reporter only
one-direction.
937a5a0
@elopio
Join the Stream and Verbose flags into verbosity (#3)
4dee14e
@elopio
Split the logger and the reporter (#4) 
The logger and the reporter should be configured independently.
We can do many improvements in the logger, but for now this change
preserves the public interfaces, keeps all the tests passing and
lets us focus on improving the reporter first.
55f12ba
@elopio
Added an interface for the reporter
8b4d3d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment