Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-wrote the middleware compress library. #401
Merged
Conversation
This re-write introduces the concept of a Compressor which stores all the settings for how compression/encoding should happen. The old API was changed to use the new Compressor struct which should prevent this change from breaking current consumers. Additionally, this uses a sync.Pool for encoders that have a Reset(io.Writer) method to reduce memory overhead.
This comment has been minimized.
This comment has been minimized.
wow @awbraunstein well done. the code looks very sharp and complete. I will review it in detail this evening. thanks for the quick turnaround |
This comment has been minimized.
This comment has been minimized.
did a review, tested various edge cases manually, and works great. thanks again @awbraunstein |
Sweet contribution! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
awbraunstein commentedFeb 26, 2019
This re-write introduces the concept of a Compressor which stores all the settings for how compression/encoding should happen. The old API was changed to use the new Compressor struct which should prevent this change from breaking current consumers.
Additionally, this uses a sync.Pool for encoders that have a Reset(io.Writer) method to reduce memory overhead.
The new API is as follows:
This fixes #397.