New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PanicHandler #335
Merged
Merged
Added PanicHandler #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Jun 3, 2022
JohnRoesler
reviewed
Jun 3, 2022
executor_test.go
Outdated
fmt.Println("PanicHandler calld:") | ||
fmt.Println("panic in " + jobName) | ||
fmt.Println(recoverData) | ||
panicHandled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we run tests with the -race flag on, so it's complaining that you reference panicHandled in the main goroutine and then inside the func here. Could you add a mutex for it and lock/unlock here as well as line 63?
JohnRoesler
reviewed
Jun 6, 2022
JohnRoesler
reviewed
Jun 6, 2022
JohnRoesler
reviewed
Jun 6, 2022
JohnRoesler
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Add global PanicHandler capability
Which issue(s) does this PR fix/relate to?
Resolves #332
List any changes that modify/break current functionality
None.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Only in the source code.