Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.13 support #1546

Merged
merged 4 commits into from Jun 30, 2019

Conversation

@aarzilli
Copy link
Member

commented May 7, 2019

goversion: update maximum supported version

proc: allow signed integers as shift counts

Go1.13 allows signed integers to be used as the right hand side of a
shift operator, change eval to match.

tests: fix tests for Go 1.13

- Go 1.13 doesn't autogenerate init functions anymore, tests that
expected that now fail and should be skipped.
- Plugin tests now need -gcflags'all=-N -l' now, we were probably
getting lucky with -gcflags='-N -l' before.

@aarzilli aarzilli force-pushed the aarzilli:go113 branch 2 times, most recently from 50cdccb to ac5fe18 May 7, 2019

@aarzilli aarzilli force-pushed the aarzilli:go113 branch from ac5fe18 to 2369a4e May 31, 2019

aarzilli added 2 commits Apr 12, 2019
tests: fix tests for Go 1.13
- Go 1.13 doesn't autogenerate init functions anymore, tests that
  expected that now fail and should be skipped.
- Plugin tests now need -gcflags'all=-N -l' now, we were probably
  getting lucky with -gcflags='-N -l' before.
proc: allow signed integers as shift counts
Go1.13 allows signed integers to be used as the right hand side of a
shift operator, change eval to match.

@aarzilli aarzilli force-pushed the aarzilli:go113 branch from 2369a4e to 66d3865 Jun 28, 2019

@aarzilli aarzilli force-pushed the aarzilli:go113 branch 2 times, most recently from 2b03982 to ea5a388 Jun 28, 2019

travis: force Go to use vendor directory
Travis scripts get confused by "go: downloading" lines, the exact
reason is not clear. Testing that the vendor directory is up to date is
a good idea anyway.

@aarzilli aarzilli force-pushed the aarzilli:go113 branch from ea5a388 to 37a9b7a Jun 28, 2019

@aarzilli aarzilli changed the title Go 1.13 support [WIP] Go 1.13 support Jun 28, 2019

@aarzilli

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

With beta1 released I think it's safe to merge this.

@derekparker
Copy link
Member

left a comment

LGTM

@derekparker derekparker merged commit 55eed31 into go-delve:master Jun 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.