Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg,service: fix typos in comments, exceptions, tests #3486

Merged
merged 1 commit into from
Aug 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/dlv/dlv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,7 @@ func TestTracePid(t *testing.T) {
assertNoError(targetCmd.Start(), t, "execute issue2023")

if targetCmd.Process == nil || targetCmd.Process.Pid == 0 {
t.Fatal("expected target process runninng")
t.Fatal("expected target process running")
}
defer targetCmd.Process.Kill()

Expand Down
2 changes: 1 addition & 1 deletion pkg/proc/proc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4565,7 +4565,7 @@ func TestCallConcurrent(t *testing.T) {

gid2 := p.SelectedGoroutine().ID
t.Logf("starting second injection in %d / %d", p.SelectedGoroutine().ID, p.CurrentThread().ThreadID())
assertNoError(proc.EvalExpressionWithCalls(grp, p.SelectedGoroutine(), "Foo(10, 2)", normalLoadConfig, false), t, "EvalExpressioniWithCalls")
assertNoError(proc.EvalExpressionWithCalls(grp, p.SelectedGoroutine(), "Foo(10, 2)", normalLoadConfig, false), t, "EvalExpressionWithCalls")

for {
returned += testCallConcurrentCheckReturns(p, t, gid1, gid2)
Expand Down
2 changes: 1 addition & 1 deletion pkg/proc/stack_sigtramp.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (it *stackIterator) readSigtrampgoContext() (*op.DwarfRegisters, error) {
case "arm64":
return sigtrampContextDarwinARM64(it.mem, addr)
default:
return nil, errors.New("not implemnted")
return nil, errors.New("not implemented")
}
default:
return nil, errors.New("not implemented")
Expand Down
2 changes: 1 addition & 1 deletion pkg/proc/variables.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const (
FloatIsNormal floatSpecial = iota
// FloatIsNaN means the float is a special NaN value.
FloatIsNaN
// FloatIsPosInf means the float is a special positive inifitiy value.
// FloatIsPosInf means the float is a special positive infinity value.
FloatIsPosInf
// FloatIsNegInf means the float is a special negative infinity value.
FloatIsNegInf
Expand Down
2 changes: 1 addition & 1 deletion pkg/terminal/starbind/conv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

func TestConv(t *testing.T) {
script := `
# A list global that we'll unmarhsal into a slice.
# A list global that we'll unmarshal into a slice.
x = [1,2]
`
globals, err := starlark.ExecFile(&starlark.Thread{}, "test.star", script, nil)
Expand Down
2 changes: 1 addition & 1 deletion service/dap/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2176,7 +2176,7 @@ func TestVariablesLoading(t *testing.T) {
checkChildren(t, tm, "tm", 1)
ref = checkVarExact(t, tm, 0, "v", "", "[]map[string]main.astruct len: 1, cap: 1, [[...]]", "[]map[string]main.astruct", hasChildren)
if ref > 0 {
// Auto-loading of fully missing map chidlren happens here, but they get trancated at MaxArrayValuess
// Auto-loading of fully missing map chidlren happens here, but they get trancated at MaxArrayValues
client.VariablesRequest(ref)
tmV := client.ExpectVariablesResponse(t)
checkChildren(t, tmV, "tm.v", 1)
Expand Down
2 changes: 1 addition & 1 deletion service/debugger/debugger.go
Original file line number Diff line number Diff line change
Expand Up @@ -2248,7 +2248,7 @@ func (d *Debugger) DumpWait(wait time.Duration) *proc.DumpState {
return &d.dumpState
}

// DumpCancel canels a dump in progress
// DumpCancel cancels a dump in progress
func (d *Debugger) DumpCancel() error {
d.dumpState.Mutex.Lock()
d.dumpState.Canceled = true
Expand Down
2 changes: 1 addition & 1 deletion service/test/integration2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2987,7 +2987,7 @@ func TestClientServer_createBreakpointWithID(t *testing.T) {
}

func TestClientServer_autoBreakpoints(t *testing.T) {
// Check that unrecoverd-panic and fatal-throw breakpoints are visible in
// Check that unrecovered-panic and fatal-throw breakpoints are visible in
// the breakpoint list.
protest.AllowRecording(t)
withTestClient2("math", t, func(c service.Client) {
Expand Down