From db662d2a6268d006dd2bdc2ca1345ec586183380 Mon Sep 17 00:00:00 2001
From: tdakkota <tanc13@yandex.ru>
Date: Fri, 12 Apr 2024 17:44:50 +0300
Subject: [PATCH] feat(lokicompliance): check if result is empty

If result is empty, instance probably did not get enough data.
---
 internal/lokicompliance/compare.go | 52 +++++++++++++++++++++++++++++-
 internal/lokicompliance/config.go  |  1 +
 internal/lokicompliance/expand.go  |  1 +
 3 files changed, 53 insertions(+), 1 deletion(-)

diff --git a/internal/lokicompliance/compare.go b/internal/lokicompliance/compare.go
index 69d544a2..d7cd2f3e 100644
--- a/internal/lokicompliance/compare.go
+++ b/internal/lokicompliance/compare.go
@@ -32,6 +32,7 @@ type TestCase struct {
 	Query          string            `json:"query"`
 	SkipComparison bool              `json:"skipComparison"`
 	ShouldFail     bool              `json:"shouldFail"`
+	ShouldBeEmpty  bool              `json:"shouldBeEmpty"`
 	Start          time.Time         `json:"start"`
 	End            time.Time         `json:"end"`
 	Step           time.Duration     `json:"step"`
@@ -103,7 +104,6 @@ func (c *Comparer) Compare(ctx context.Context, tc *TestCase) (*Result, error) {
 		}
 		return nil, errors.Errorf("expected reference API query %q to fail, but succeeded", tc.Query)
 	}
-
 	if (testErr != nil) != tc.ShouldFail {
 		if testErr != nil {
 			var unsupported bool
@@ -123,12 +123,62 @@ func (c *Comparer) Compare(ctx context.Context, tc *TestCase) (*Result, error) {
 		return &Result{TestCase: tc}, nil
 	}
 
+	if err := checkEmpty(refResult.Data, tc.ShouldBeEmpty); err != nil {
+		return nil, err
+	}
+	if err := checkEmpty(testResult.Data, tc.ShouldBeEmpty); err != nil {
+		return &Result{
+			TestCase:          tc,
+			UnexpectedFailure: err.Error(),
+		}, nil
+	}
+
 	return &Result{
 		TestCase: tc,
 		Diff:     cmp.Diff(refResult, testResult, c.compareOptions),
 	}, nil
 }
 
+func checkEmpty(data lokiapi.QueryResponseData, shouldBeEmpty bool) error {
+	dataIsEmpty := isEmpty(data)
+	if dataIsEmpty != shouldBeEmpty {
+		msg := "non-empty"
+		if dataIsEmpty {
+			msg = "empty"
+		}
+		return errors.Errorf("unexpected %s result", msg)
+	}
+	return nil
+}
+
+func isEmpty(data lokiapi.QueryResponseData) bool {
+	switch data.Type {
+	case lokiapi.StreamsResultQueryResponseData:
+		r, _ := data.GetStreamsResult()
+		for _, s := range r.Result {
+			if len(s.Values) > 0 {
+				return false
+			}
+		}
+		return true
+	case lokiapi.ScalarResultQueryResponseData:
+		return false
+	case lokiapi.VectorResultQueryResponseData:
+		r, _ := data.GetVectorResult()
+		return len(r.Result) < 1
+	case lokiapi.MatrixResultQueryResponseData:
+		r, _ := data.GetMatrixResult()
+		for _, s := range r.Result {
+			if len(s.Values) > 0 {
+				return false
+			}
+		}
+		return true
+	default:
+		return true
+	}
+}
+
 type fpoint struct {
 	T float64
 	V float64
diff --git a/internal/lokicompliance/config.go b/internal/lokicompliance/config.go
index 3872201f..4f7cbf2d 100644
--- a/internal/lokicompliance/config.go
+++ b/internal/lokicompliance/config.go
@@ -24,6 +24,7 @@ type TestCasePattern struct {
 	VariantArgs    []string `yaml:"variant_args,omitempty"`
 	SkipComparison bool     `yaml:"skip_comparison,omitempty"`
 	ShouldFail     bool     `yaml:"should_fail,omitempty"`
+	ShouldBeEmpty  bool     `yaml:"should_be_empty,omitempty"`
 }
 
 type QueryParameters struct {
diff --git a/internal/lokicompliance/expand.go b/internal/lokicompliance/expand.go
index 67d8d9e3..37213a35 100644
--- a/internal/lokicompliance/expand.go
+++ b/internal/lokicompliance/expand.go
@@ -105,6 +105,7 @@ func ExpandQuery(cfg *Config, start, end time.Time, step time.Duration) (r []*Te
 					Query:          query,
 					SkipComparison: tc.SkipComparison,
 					ShouldFail:     tc.ShouldFail,
+					ShouldBeEmpty:  tc.ShouldBeEmpty,
 					Start:          start,
 					End:            end,
 					Step:           step,