Implement ForgeFed vocabulary. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caveat: the "description" property is probably wrong; it should match the definition of the ActivityPub(!) "source" property which is currently not in go-fed.
|
Do you mind adding the "source" property to the activitypub spec? I think it was an oversight on my part, and once that is reviewed, I can easily double-check the "description" property here. If I don't hear back in a day or two, I'll make an attempt at supporting the "source" property. |
|
I'm going to tackle adding the |
|
FYI, 2d143b2 contains the shiny new |
cjslep
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveat: the "description" property is probably wrong; it should match the definition of the ActivityPub(!) "source" property which is currently not in go-fed.