Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on making deployment more robust and without ASG. #57

Merged
merged 6 commits into from Aug 15, 2019

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Aug 15, 2019

Closes #55

@coveralls
Copy link

coveralls commented Aug 15, 2019

Pull Request Test Coverage Report for Build 443

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 75.451%

Totals Coverage Status
Change from base Build 431: 0.4%
Covered Lines: 627
Relevant Lines: 831

💛 - Coveralls

@Skarlso
Copy link
Member Author

Skarlso commented Aug 15, 2019

Haha,

2019-08-15 05:35:59 ERROR [codedeploy-agent(12354)]: InstanceAgent::Plugins::CodeDeployPlugin::CommandPoller: Missing credentials - please check if this instance was started with an IAM instance profile

@Skarlso
Copy link
Member Author

Skarlso commented Aug 15, 2019

This isn't right. I had to give an S3 bucket policy to codedeploy even though it's not using the bucket. I think the template is just not right. I'll fix that.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 15, 2019

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "",
            "Effect": "Allow",
            "Principal": {
                "Service": [
                    "codedeploy.amazonaws.com"
                ]
            },
            "Action": "sts:AssumeRole"
        }
    ]
}

I need a code deploy iam role for the ec2 instance.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 15, 2019

Screenshot 2019-08-15 at 07 52 12

This now works, but I have to optimise the template so as to not require a codedeploybucket.

@Skarlso Skarlso merged commit 9ffd479 into master Aug 15, 2019
@Skarlso
Copy link
Member Author

Skarlso commented Aug 15, 2019

Closes #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable getting deployment status
2 participants