This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
Move main logic to /generator and Refactor it #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuzu
commented
Nov 22, 2021
| }, | ||
| "UpdateFunc": func() string { | ||
| return fmt.Sprintf("Update(ctx context.Context, subject *%s) (err error)", g.StructNameRef) | ||
| return fmt.Sprintf("Update(ctx context.Context, subject *%s) (err error)", g.param.StructNameRef) |
There was a problem hiding this comment.
本当はここら辺はtemplateで完結できるようにしたい
|
os.WriteFileがなくて落ちている・・・Goのバージョンを上げます |
|
ldflagsのここが漏れ firestore-repo/.goreleaser.yml Line 15 in 3cca172 |
tsuzu
changed the title
tsuzu
changed the title
54m
suggested changes
Nov 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generator部分の実装は適宜structに分割しつつ
generator/以下、その他ユーティリティはpkg/以下におきましたdebug.ReadBuildInfo()でバージョン読む実装もついでに追加しました