Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: Allow srcPrefix and dstPrefix to be configured #265

Merged
merged 2 commits into from Mar 11, 2021

Conversation

@yabberyabber
Copy link
Contributor

@yabberyabber yabberyabber commented Mar 9, 2021

The default behavior here remains the same, but this change does
allow consumers of the UnifiedEncoder to set their own path prefixes
which will override the defaults of a/ and b/.

Setting this should be analogous to setting --src-prefix and
--dst-prefix in git diff.

See https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---src-prefixltprefixgt

@yabberyabber
Copy link
Contributor Author

@yabberyabber yabberyabber commented Mar 9, 2021

I believe these failures are unrelated to my change. Ref #51

Is there a way I can configure this change to re-check without submitting an arbitrary change?

The default behavior here remains the same, but this change does
allow consumers of the UnifiedEncoder to set their own path prefixes
which will override the defaults of a/ and b/.
@yabberyabber yabberyabber marked this pull request as draft Mar 9, 2021
@yabberyabber yabberyabber marked this pull request as ready for review Mar 9, 2021
@mcuadros
Copy link
Member

@mcuadros mcuadros commented Mar 10, 2021

Can you provide some tests?
Thanks

@yabberyabber
Copy link
Contributor Author

@yabberyabber yabberyabber commented Mar 10, 2021

Can you provide some tests?
Thanks

Yep - latest patchset has a test which covers non-default prefixes

@mcuadros mcuadros merged commit 55ba7b2 into go-git:master Mar 11, 2021
9 checks passed
@yabberyabber
Copy link
Contributor Author

@yabberyabber yabberyabber commented Mar 15, 2021

@mcuadros Can we cut of a new release of go-git? Quite a few things have changed since 5.2 and it would be nice to be able to import these changes with go modules

@mcuadros
Copy link
Member

@mcuadros mcuadros commented Mar 29, 2021

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants