This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| // Copyright 2023 The Gitea Authors. All rights reserved. | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| package git | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/hex" | ||
| "errors" | ||
| "fmt" | ||
| "hash" | ||
| "strconv" | ||
| "strings" | ||
| ) | ||
|
|
||
| type ObjectID interface { | ||
| String() string | ||
| IsZero() bool | ||
| RawValue() []byte | ||
| Type() ObjectFormat | ||
| } | ||
|
|
||
| /* SHA1 */ | ||
| type Sha1Hash [20]byte | ||
|
|
||
| func (h *Sha1Hash) String() string { | ||
| return hex.EncodeToString(h[:]) | ||
| } | ||
|
|
||
| func (h *Sha1Hash) IsZero() bool { | ||
| empty := Sha1Hash{} | ||
| return bytes.Equal(empty[:], h[:]) | ||
| } | ||
| func (h *Sha1Hash) RawValue() []byte { return h[:] } | ||
| func (*Sha1Hash) Type() ObjectFormat { return &Sha1ObjectFormat{} } | ||
|
|
||
| func NewSha1() *Sha1Hash { | ||
| return &Sha1Hash{} | ||
| } | ||
|
|
||
| // generic implementations | ||
| func NewHash(hash string) (ObjectID, error) { | ||
| hash = strings.ToLower(hash) | ||
| switch hash { | ||
| case "sha1": | ||
| return &Sha1Hash{}, nil | ||
| } | ||
|
|
||
| return nil, errors.New("unsupported hash type") | ||
| } | ||
|
|
||
| func IDFromRaw(h ObjectFormat, b []byte) (ObjectID, error) { | ||
| if len(b) != h.FullLength()/2 { | ||
| return h.Empty(), fmt.Errorf("length must be %d: %v", h.FullLength(), b) | ||
| } | ||
| return h.MustID(b), nil | ||
| } | ||
|
|
||
| func MustIDFromString(h ObjectFormat, s string) ObjectID { | ||
| b, _ := hex.DecodeString(s) | ||
| return h.MustID(b) | ||
| } | ||
|
|
||
| func genericIDFromString(h ObjectFormat, s string) (ObjectID, error) { | ||
| s = strings.TrimSpace(s) | ||
| if len(s) != h.FullLength() { | ||
| return h.Empty(), fmt.Errorf("length must be %d: %s", h.FullLength(), s) | ||
| } | ||
| b, err := hex.DecodeString(s) | ||
| if err != nil { | ||
| return h.Empty(), err | ||
| } | ||
| return h.NewID(b) | ||
| } | ||
|
|
||
| // utils | ||
| func IDFromString(hexHash string) (ObjectID, error) { | ||
| switch len(hexHash) { | ||
| case 40: | ||
| hashType := Sha1ObjectFormat{} | ||
| h, err := hashType.NewIDFromString(hexHash) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return h, nil | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("invalid hash hex string: '%s' len: %d", hexHash, len(hexHash)) | ||
| } | ||
|
|
||
| func IsEmptyCommitID(commitID string) bool { | ||
| if commitID == "" { | ||
| return true | ||
| } | ||
|
|
||
| id, err := IDFromString(commitID) | ||
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| return id.IsZero() | ||
| } | ||
|
|
||
| // HashInterface is a struct that will generate a Hash | ||
| type HasherInterface interface { | ||
| hash.Hash | ||
|
|
||
| HashSum() ObjectID | ||
| } | ||
|
|
||
| type Sha1Hasher struct { | ||
| hash.Hash | ||
| } | ||
|
|
||
| // ComputeBlobHash compute the hash for a given blob content | ||
| func ComputeBlobHash(hashType ObjectFormat, content []byte) ObjectID { | ||
| return ComputeHash(hashType, ObjectBlob, content) | ||
| } | ||
|
|
||
| // ComputeHash compute the hash for a given ObjectType and content | ||
| func ComputeHash(hashType ObjectFormat, t ObjectType, content []byte) ObjectID { | ||
| h := hashType.NewHasher() | ||
| _, _ = h.Write(t.Bytes()) | ||
| _, _ = h.Write([]byte(" ")) | ||
| _, _ = h.Write([]byte(strconv.FormatInt(int64(len(content)), 10))) | ||
| _, _ = h.Write([]byte{0}) | ||
| return h.HashSum() | ||
|
Contributor
There was a problem hiding this comment. Here and below, a regression ..... the "content" is not written into the hasher 😭 -> Fix incorrect object id hash function #30708 |
||
| } | ||
|
|
||
| // Sum generates a SHA1 for the provided hash | ||
| func (h *Sha1Hasher) HashSum() ObjectID { | ||
| var sha1 Sha1Hash | ||
| copy(sha1[:], h.Hash.Sum(nil)) | ||
| return &sha1 | ||
| } | ||
|
|
||
| type ErrInvalidSHA struct { | ||
| SHA string | ||
| } | ||
|
|
||
| func (err ErrInvalidSHA) Error() string { | ||
| return fmt.Sprintf("invalid sha: %s", err.SHA) | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it needs "integer" number?
I think
type ObjectFormat stringandSha1 = "sha1"work better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another function that does this from
stringalready, at the bottom of the file.git.ObjectFormatFromString()Basically, there is no need for this to be int or string in particular, but I wanted to move at least temporarily away from string to catch errors like passing "SHA1" vs. "sha1".
Finally, maybe my prejudice shows, coming from C and C++ world shows, where enums are ints 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#28469