Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary parentheses in wiki/view template #10583

Merged
merged 2 commits into from Mar 3, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 3, 2020

For 3 years go has happily been interpreting or (x y z) as or x y z>. Go 1.14 does not...

Fix #10552

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #10583 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10583      +/-   ##
==========================================
- Coverage   43.76%   43.71%   -0.05%     
==========================================
  Files         584      585       +1     
  Lines       81663    82026     +363     
==========================================
+ Hits        35737    35855     +118     
- Misses      41490    41730     +240     
- Partials     4436     4441       +5
Impacted Files Coverage Δ
models/user_mail.go 48.27% <0%> (-15.92%) ⬇️
modules/notification/action/action.go 39.34% <0%> (-1.23%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
modules/notification/webhook/webhook.go 40.18% <0%> (-0.48%) ⬇️
services/pull/pull.go 34.7% <0%> (-0.2%) ⬇️
services/pull/merge.go 49.34% <0%> (-0.12%) ⬇️
routers/user/auth.go 11.33% <0%> (-0.07%) ⬇️
models/oauth2.go 34.04% <0%> (ø) ⬆️
routers/admin/emails.go 0% <0%> (ø)
routers/routes/routes.go 86.34% <0%> (+0.06%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ecc82...1830d0e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2020
@lunny lunny merged commit 009990b into go-gitea:master Mar 3, 2020
@zeripath zeripath deleted the Fix-10552 branch March 3, 2020 22:42
pvgoran added a commit to pvgoran/gitea that referenced this pull request Jun 6, 2020
@techknowlogick techknowlogick added backport/done All backports for this PR have been created backport/v1.11 labels Jun 6, 2020
zeripath pushed a commit that referenced this pull request Jun 6, 2020
It's a backport of #10583 to version 1.11.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiki template error with golang 1.14
7 participants