Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vendor] github.com/pquerna/otp: untagged -> v1.2.0 #11358

Merged
merged 1 commit into from
May 10, 2020
Merged

[Vendor] github.com/pquerna/otp: untagged -> v1.2.0 #11358

merged 1 commit into from
May 10, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 9, 2020

Update github.com/pquerna/otp from untagged to v1.2.0

@techknowlogick techknowlogick added this to the 1.12.0 milestone May 9, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 9, 2020
zeripath
zeripath approved these changes May 9, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in the changelog - secret size has doubled - users should be recommended to regenerate secrets for their totp

Not relevant

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2020
@zeripath
Copy link
Contributor

zeripath commented May 9, 2020

gitea/routers/user/setting/security_twofa.go

Line 85 in b0cd3b8

SecretSize: 40,
we already set it to 40

@6543
Copy link
Member Author

6543 commented May 10, 2020

ping lgtm

@lafriks lafriks merged commit 43bb859 into go-gitea:master May 10, 2020
@lafriks lafriks deleted the vendor_otp_v1.2.0 branch May 10, 2020 12:50
@zeripath zeripath mentioned this pull request May 17, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Update github.com/pquerna/otp from untagged to v1.2.0 (go-gitea#11358)
cee1e3f
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @zeripath @lafriks @techknowlogick @GiteaBot