Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goldmark default table can't deal this correctly, **xxx** before table with only \n #12376

Closed
1 of 3 tasks
jacky-2014-sn opened this issue Jul 30, 2020 · 2 comments · Fixed by #12377
Closed
1 of 3 tasks

goldmark default table can't deal this correctly, **xxx** before table with only \n #12376

jacky-2014-sn opened this issue Jul 30, 2020 · 2 comments · Fixed by #12377
Labels
type/upstream This is an issue in one of Gitea's dependencies and should be reported there

Comments

@jacky-2014-sn
Copy link

jacky-2014-sn commented Jul 30, 2020 •
edited
Loading

Description

**xxx**
| hello |   hi  |
| :----: | :----:|

text as this, will show incorrectly in try.gitea.io

Screenshots

LXTFV%BAKTC1L 2)`QSYVRT

NWG4XER675O~I$ VPD`H0GF
@jacky-2014-sn jacky-2014-sn changed the title goldmardown default table can't deal this correctly, **xxx** before table with only \n goldmark default table can't deal this correctly, **xxx** before table with only \n Jul 30, 2020
@zeripath zeripath mentioned this issue Jul 30, 2020
Closed
4 tasks
@zeripath
Copy link
Contributor

This appears to be a bug in the underlying library - Goldmark and I've opened an issue there.

@zeripath zeripath added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Jul 30, 2020
@yuin
Copy link

yuin commented Jul 30, 2020

goldmark author here.

Thanks for reporting this.
I've fixed the issue and made a new release.

a1012112796 added a commit to a1012112796/gitea that referenced this issue Jul 30, 2020
@a1012112796
Vendor update: github.com/yuin/goldmark v1.2.1
91e669e 
Thanks to @yuin

fix go-gitea#12376
@a1012112796 a1012112796 mentioned this issue Jul 30, 2020
Merged
techknowlogick pushed a commit that referenced this issue Jul 30, 2020
@a1012112796
Vendor update: github.com/yuin/goldmark v1.2.1 (#12377)
7e96268 
Thanks to @yuin

fix #12376
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vendor update: github.com/yuin/goldmark v1.2.1 a1012112796/gitea
3 participants
@yuin @zeripath @jacky-2014-sn