Inline comments on commits and pull files #124

lunny · Nov 9, 2016

Before we can start a review, we can implement comment on one line of PRs at first.
I think this includes two sub issues.

Commit comment #3748
Pull files comment #3748

well, If we implement comments on commits we should get this "for free" 🙂

bkcsoft · Nov 9, 2016

well, If we implement comments on commits we should get this "for free" 🙂

I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

metalmatze · Nov 9, 2016

I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

Yes, comment on commits.

lunny · Nov 10, 2016

Yes, comment on commits.

I can probably make a proof of concept for this sometime during the weekend or next week

bkcsoft · Dec 6, 2016

I can probably make a proof of concept for this sometime during the weekend or next week

@bkcsoft any update?

lunny · Jan 26, 2017

@bkcsoft any update?

Aren't we going to do this with git-appraise ? See #733

strk · Jan 26, 2017

Aren't we going to do this with git-appraise ? See #733

I can look at this, but this will be not so fast

sokolovstas · Jan 26, 2017

I can look at this, but this will be not so fast

Move this v1.2 since #733 has moved.

lunny · Feb 14, 2017

Move this v1.2 since #733 has moved.

I have tried to do something. Comments on PR is not the same as comments on commits. These are two similar PRs. For comments on PR, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for comments on commits, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).

lunny · Feb 14, 2017

I have tried to do something. Comments on PR is not the same as comments on commits. These are two similar PRs. For comments on PR, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for comments on commits, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).

I send the draft as seen to comment on the code.
For some time I will show demo work.

lcges · Sep 12, 2017

I send the draft as seen to comment on the code.
For some time I will show demo work.

Hello.
I send you a preview of the model of action.
This is a static implementation - proof of concept

gitea_comment_code.zip

lcges · Sep 22, 2017

Hello.
I send you a preview of the model of action.
This is a static implementation - proof of concept

gitea_comment_code.zip

@qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?

daviian · Sep 22, 2017

@qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?

gitea_c_o_c.zip

I send updated versions.
I'm waiting for comments on this.

lcges · Sep 22, 2017

gitea_c_o_c.zip

I send updated versions.
I'm waiting for comments on this.

@qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.

lunny · Sep 22, 2017

@qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.

@qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?

lunny · Sep 22, 2017

@qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?

@qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.

lunny · Sep 23, 2017

@qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.

no problem. I will do what I need
I'll take your code and I'm already working on the correct code.

lcges · Sep 25, 2017

no problem. I will do what I need
I'll take your code and I'm already working on the correct code.

@qdbdbp, what tool do you use to do those designs? 😅

xxxtonixxx · Sep 25, 2017

@qdbdbp, what tool do you use to do those designs? 😅

hi. I use it for quick drafts this tool:

https://mockflow.com/

lcges · Sep 25, 2017

hi. I use it for quick drafts this tool:

https://mockflow.com/

I don't mind to pay to have this feature... how much? who?

bclermont · Mar 13, 2018

I don't mind to pay to have this feature... how much? who?

@bclermont we already have a wip pull request #2583.

lunny · Mar 13, 2018

@bclermont we already have a wip pull request #2583.

@lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature

bclermont · Mar 13, 2018

@lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature

You could use https://www.bountysource.com/teams/go-gitea

lunny · Mar 13, 2018

You could use https://www.bountysource.com/teams/go-gitea

@lunny thanks for posting that link. I added to the bounty.

techknowlogick · Mar 14, 2018

@lunny thanks for posting that link. I added to the bounty.

Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the only feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!

cobbzilla · Mar 28, 2018

Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the only feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!

I will give equivalent of 100$ in a crypto currency to whoever earn the bounty

bclermont · Mar 29, 2018

I will give equivalent of 100$ in a crypto currency to whoever earn the bounty

Are there things to follow?

rc1021 · May 4, 2018

Are there things to follow?

Please follow #3748

lunny · May 4, 2018

Please follow #3748

lunny added kind/proposal kind/feature labels Nov 9, 2016

lunny added this to the 1.1.0 milestone Nov 9, 2016

lunny changed the title from Inline comments on prs to Inline comments on commits Nov 10, 2016

rikvdh referenced this issue Jan 26, 2017
Open
First implementation of git appraise #733

lunny modified the milestones: 1.2.0, 1.1.0 Feb 14, 2017

lunny referenced this issue Feb 23, 2017
Open
Gitea hosted Gitea #1029
6 of 8 tasks complete

lunny modified the milestones: 1.x.x, 1.2.0 Apr 20, 2017

lunny referenced this issue May 31, 2017
Closed
Comment on the code #1840

lunny referenced this issue Sep 1, 2017
Closed
Comments of code #2443

lunny referenced this issue Sep 23, 2017
Closed
Comments on pull files #2583

lunny changed the title from Inline comments on commits to Inline comments on commits and pull files Sep 23, 2017

krombel referenced this issue Feb 26, 2018
Closed
Add ability to review changes as in github #3580

lafriks modified the milestones: 1.x.x, 1.5.0 Apr 2, 2018

lafriks referenced this issue Apr 2, 2018
Merged
Pull request review/approval and comment on code #3748
22 of 23 tasks complete

lafriks modified the milestones: 1.5.0, 1.6.0 Jun 5, 2018

JonasFranzDEV closed this in #3748 Aug 6, 2018

go-gitea/gitea

Join GitHub today

Inline comments on commits and pull files #124

Comments

lunny commented Nov 9, 2016 • edited Edited 2 times lunny edited Aug 6, 2018 (most recent) lunny edited Sep 23, 2017

lunny added kind/proposal kind/feature labels Nov 9, 2016

lunny added this to the 1.1.0 milestone Nov 9, 2016

This comment has been minimized.

bkcsoft commented Nov 9, 2016 • edited Edited 1 time bkcsoft edited Nov 9, 2016 (most recent)

This comment has been minimized.

metalmatze commented Nov 9, 2016

This comment has been minimized.

lunny commented Nov 10, 2016

lunny changed the title from Inline comments on prs to Inline comments on commits Nov 10, 2016

This comment has been minimized.

bkcsoft commented Dec 6, 2016

This comment has been minimized.

lunny commented Jan 26, 2017

This comment has been minimized.

strk commented Jan 26, 2017

rikvdh referenced this issue Jan 26, 2017

This comment has been minimized.

sokolovstas commented Jan 26, 2017

lunny modified the milestones: 1.2.0, 1.1.0 Feb 14, 2017

This comment has been minimized.

lunny commented Feb 14, 2017

This comment has been minimized.

lunny commented Feb 14, 2017

lunny referenced this issue Feb 23, 2017

lunny modified the milestones: 1.x.x, 1.2.0 Apr 20, 2017

lunny referenced this issue May 31, 2017

lunny referenced this issue Sep 1, 2017

This comment has been minimized.

lcges commented Sep 12, 2017

This comment has been minimized.

lcges commented Sep 22, 2017

This comment has been minimized.

daviian commented Sep 22, 2017 • edited Edited 1 time daviian edited Sep 22, 2017 (most recent)

This comment has been minimized.

lcges commented Sep 22, 2017

This comment has been minimized.

lunny commented Sep 22, 2017

This comment has been minimized.

lunny commented Sep 22, 2017

lunny referenced this issue Sep 23, 2017

This comment has been minimized.

lunny commented Sep 23, 2017

lunny changed the title from Inline comments on commits to Inline comments on commits and pull files Sep 23, 2017

This comment has been minimized.

lcges commented Sep 25, 2017

This comment has been minimized.

xxxtonixxx commented Sep 25, 2017

This comment has been minimized.

lcges commented Sep 25, 2017

krombel referenced this issue Feb 26, 2018

This comment has been minimized.

bclermont commented Mar 13, 2018

This comment has been minimized.

lunny commented Mar 13, 2018

This comment has been minimized.

bclermont commented Mar 13, 2018

This comment has been minimized.

lunny commented Mar 13, 2018

This comment has been minimized.

techknowlogick commented Mar 14, 2018

This comment has been minimized.

cobbzilla commented Mar 28, 2018

This comment has been minimized.

bclermont commented Mar 29, 2018

lafriks modified the milestones: 1.x.x, 1.5.0 Apr 2, 2018

lafriks referenced this issue Apr 2, 2018

This comment has been minimized.

rc1021 commented May 4, 2018

This comment has been minimized.

lunny commented May 4, 2018

lafriks modified the milestones: 1.5.0, 1.6.0 Jun 5, 2018

JonasFranzDEV closed this in #3748 Aug 6, 2018

lunny commented Nov 9, 2016 •

edited

Edited 2 times

lunny edited Aug 6, 2018 (most recent)

lunny edited Sep 23, 2017

bkcsoft commented Nov 9, 2016 •

edited

Edited 1 time

bkcsoft edited Nov 9, 2016 (most recent)

daviian commented Sep 22, 2017 •

edited

Edited 1 time

daviian edited Sep 22, 2017 (most recent)