Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macaron 1.5 #12596

Merged
merged 10 commits into from
Aug 28, 2020
Merged

Macaron 1.5 #12596

merged 10 commits into from
Aug 28, 2020

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 24, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 24, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 25, 2020
@lafriks
Copy link
Member

lafriks commented Aug 25, 2020

Compilation seems to fail

@techknowlogick
Copy link
Member Author

Macaron now supports HTTP/2 Push mode and so gitea.com/macaron/gzip will need to implement the Push method. I've pushed a branch which may become a PR soon to that repo.

@techknowlogick techknowlogick added the pr/wip This PR is not ready for review label Aug 26, 2020
@techknowlogick
Copy link
Member Author

Blocked by https://gitea.com/macaron/gzip/pulls/3

@lafriks
Copy link
Member

lafriks commented Aug 27, 2020

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #12596 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12596      +/-   ##
==========================================
+ Coverage   43.43%   43.45%   +0.01%     
==========================================
  Files         645      645              
  Lines       71304    71306       +2     
==========================================
+ Hits        30974    30986      +12     
+ Misses      35320    35311       -9     
+ Partials     5010     5009       -1     
Impacted Files Coverage Δ
modules/test/context_tests.go 47.82% <0.00%> (-1.07%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
modules/log/event.go 58.49% <0.00%> (+0.94%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
services/gitdiff/gitdiff.go 76.35% <0.00%> (+1.80%) ⬆️
modules/charset/charset.go 70.78% <0.00%> (+2.24%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211321f...307284c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 27, 2020
@techknowlogick techknowlogick merged commit c5d5d63 into go-gitea:master Aug 28, 2020
@techknowlogick techknowlogick deleted the macaron-1.5 branch August 28, 2020 02:47
@techknowlogick techknowlogick removed the pr/wip This PR is not ready for review label Aug 28, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants