Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Avatar Resize (resize algo NearestNeighbor -> Bilinear) #12745

Merged
merged 5 commits into from Sep 6, 2020
Merged

Fix Avatar Resize (resize algo NearestNeighbor -> Bilinear) #12745

merged 5 commits into from Sep 6, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 6, 2020 •
edited

Adidtional Info: https://en.wikipedia.org/wiki/Image_scaling

this fix #12631
original:
orig
new gitea avatar:
77e40566a8b6ebe66a621787067199bd

PS: some edge pixels are cut away because of tests (the file hash must differ to recalc ...) so this is no bug in the demo

@6543 6543 changed the title Fix avatar resize Fix Avatar Resize (resize algo NearestNeighbor -> Bilinear) Sep 6, 2020
@6543 6543 added the type/bug label Sep 6, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 6, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2020 •
edited

Codecov Report

Merging #12745 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12745      +/-   ##
==========================================
- Coverage   43.40%   43.39%   -0.01%     
==========================================
  Files         648      648              
  Lines       71581    71581              
==========================================
- Hits        31069    31066       -3     
- Misses      35485    35486       +1     
- Partials     5027     5029       +2
Impacted Files Coverage Δ
routers/api/v1/repo/file.go 64.00% <ø> (ø)
modules/avatar/avatar.go 50.00% <100.00%> (ø)
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/log/event.go 56.60% <0.00%> (-0.95%) ⬇️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+8.69%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332dbe7...51419f4. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Sep 6, 2020

ready to 🚀

@zeripath zeripath merged commit f7b3e06 into go-gitea:master Sep 6, 2020
@zeripath
Copy link
Contributor

zeripath commented Sep 6, 2020

Please send backport

@6543 6543 deleted the fix-avatar-resize branch September 6, 2020 19:58
6543 added a commit to 6543-forks/gitea that referenced this pull request Sep 6, 2020
@6543
Fix Avatar Resize (resize algo NearestNeighbor -> Bilinear) (go-gitea…
f6cde64 
…#12745)

* Update Vendor github.com/nfnt/resize

* switch resize algo NearestNeighbor -> Bilinear
@6543 6543 mentioned this pull request Sep 6, 2020
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Sep 6, 2020
@6543
Copy link
Member Author

6543 commented Sep 6, 2020

Backport -> #12750

zeripath pushed a commit that referenced this pull request Sep 6, 2020
@6543
Fix Avatar Resize (resize algo NearestNeighbor -> Bilinear) (#12745) (#…
0bb56a4 
…12750)

* Update Vendor github.com/nfnt/resize

* switch resize algo NearestNeighbor -> Bilinear
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Artifacts on geometric avatar
5 participants
@6543 @codecov-commenter @zeripath @techknowlogick @GiteaBot