Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show original author's reviews on pull summary box #13127

Merged
merged 3 commits into from Oct 14, 2020
Merged

Show original author's reviews on pull summary box #13127

merged 3 commits into from Oct 14, 2020

Conversation

a1012112796
Copy link
Member

follow #12039, show original author's reviews by other way.
fix #11705.

2020-10-13 11-56-25屏幕截图

2020-10-13 11-56-42屏幕截图

@a1012112796
Show original author's reviews on pull summary box
b5b608c 
follow go-gitea#12039, show original author's reviews by other way.
fix go-gitea#11705.

Signed-off-by: a1012112796 <1012112796@qq.com>
@codecov-io
Copy link

codecov-io commented Oct 13, 2020 •
edited

Codecov Report

Merging #13127 into master will increase coverage by 0.00%.
The diff coverage is 58.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13127   +/-   ##
=======================================
  Coverage   42.09%   42.09%           
=======================================
  Files         678      678           
  Lines       75029    75041   +12     
=======================================
+ Hits        31580    31591   +11     
- Misses      38298    38310   +12     
+ Partials     5151     5140   -11
Impacted Files Coverage Δ
routers/repo/issue.go 34.93% <40.00%> (+0.01%) ⬆️
models/review.go 36.32% <71.42%> (+0.47%) ⬆️
services/pull/check.go 35.76% <0.00%> (-13.14%) ⬇️
models/pull.go 54.54% <0.00%> (-0.63%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
models/error.go 34.72% <0.00%> (+0.83%) ⬆️
models/notification.go 66.66% <0.00%> (+0.90%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/log/event.go 61.79% <0.00%> (+1.88%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70df67...2e453eb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 13, 2020
@6543 6543 added the type/bug label Oct 13, 2020
@lafriks lafriks added this to the 1.13.0 milestone Oct 14, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2020
@6543
Copy link
Member

6543 commented Oct 14, 2020

🚀

@zeripath zeripath merged commit 9798014 into go-gitea:master Oct 14, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Weird behavior when migrating from Github to gitea.com
6 participants
@a1012112796 @codecov-io @6543 @lafriks @zeripath @GiteaBot