Store task errors following migrations and display them #13246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrate tasks fail store the error in the task table and ensure that they show on the status page. Fix go-gitea#13242 Signed-off-by: Andrew Thornton <art27@cantab.net>
mrsdizzie
approved these changes
Oct 22, 2020
GiteaBot
added
the
lgtm/need 1
lunny
reviewed
Oct 22, 2020
silverwind
reviewed
Oct 22, 2020
|
on migration screen loading you can see the broken for a split of a second before normal progress icon is shown |
Signed-off-by: Andrew Thornton <art27@cantab.net>
…path/gitea into fix-13242-ensure-errors-set-in-task
|
OK try now |
Codecov Report
@@ Coverage Diff @@
## master #13246 +/- ##
==========================================
+ Coverage 42.17% 42.19% +0.01%
==========================================
Files 684 685 +1
Lines 75549 75571 +22
==========================================
+ Hits 31866 31886 +20
- Misses 38460 38462 +2
Partials 5223 5223
Continue to review full report at Codecov.
|
techknowlogick
approved these changes
Oct 23, 2020
GiteaBot
added
lgtm/done
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 24, 2020
* Store task errors following migrations and display them When migrate tasks fail store the error in the task table and ensure that they show on the status page. Fix go-gitea#13242 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update web_src/js/index.js * Hide the failed first Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
|
Backported in #13287 |
techknowlogick
added
the
backport/done
lunny
pushed a commit
that referenced
this pull request
Oct 24, 2020
) * Store task errors following migrations and display them When migrate tasks fail store the error in the task table and ensure that they show on the status page. Fix #13242 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update web_src/js/index.js * Hide the failed first Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrate tasks fail store the error in the task table
and ensure that they show on the status page.
Fix #13242
Signed-off-by: Andrew Thornton art27@cantab.net