Complete notifications system

[andreynering]

Today Gitea can send e-mail for new Issues/PRs/Comments and that's it.

I think it should have a complete notifications system, like GitHub and GitLab.

• Notifications would be saved in a database table
• A page to manage them. Equivalent to https://github.com/notifications
• Mark as read/unread, pinning a notification (visible even if read)
• Subscribe/Unsubscribe button
• Mark all notifications as read
• Mark all notifications as unread
• Automatic subscribe on Open/Comment, etc
• Also more refined watch options?
• E-mail read means notification gone. Each user should have the ability to disable this
• E-Mail notifications for pushes

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[lunny]

If you watch some repository, then defaultly, you will subscribe all the issues and prs on this repository except you unsubscribe this issue.

[lunny]

If you watch some repository, then defaultly, you will subscribe all the issues and prs on this repository except you unsubscribe this issue.

[bkcsoft]

Please implement notifications like GitLab does, where you actually have to press "I'm done with this" before it goes away 🙂

[bkcsoft]

Please implement notifications like GitLab does, where you actually have to press "I'm done with this" before it goes away 🙂

[stevenroose]

If you add an "e-mail read means notification gone" system like GitHub's, please make it opt-out :)

[stevenroose]

If you add an "e-mail read means notification gone" system like GitHub's, please make it opt-out :)

[lunny]

@stevenroose that is a great idea. I think I can implement it.

[lunny]

@stevenroose that is a great idea. I think I can implement it.

[lunny]

@andreynering could you add e-mail read means notification gone to the check list?

[lunny]

@andreynering could you add e-mail read means notification gone to the check list?

[andreynering]

@lunny @stevenroose Updated

GitHub implements that by having a 1px-1px transparent image which point to https://github.com/some-route?token=.... When the GitHub server serve that image for the first time the notification is marked as read.

[andreynering]

@lunny @stevenroose Updated

GitHub implements that by having a 1px-1px transparent image which point to https://github.com/some-route?token=.... When the GitHub server serve that image for the first time the notification is marked as read.

[lunny]

Yes. A small trick. :)

[lunny]

Yes. A small trick. :)

[stevenroose]

@andreynering I know they do it like that. But most e-mail clients don't have a feature to block displaying emails from specific senders :) So if you don't like that feature, it can be annoying.

[stevenroose]

@andreynering I know they do it like that. But most e-mail clients don't have a feature to block displaying emails from specific senders :) So if you don't like that feature, it can be annoying.

[tboerger]

👍 for opt-out of this feature.

[tboerger]

👍 for opt-out of this feature.

[stevenroose]

@tboerger Don't get me wrong. I got to like the e-mail thing because now I read all my GitHub stuff from e-mail. But for someone who doesn't it be annoying. I had a lot of "ah, let me quickly check this issue in my email and look at it further tonight" and then I ended up not finding the issue and ploughing through archived e-mails to find it back :D

[stevenroose]

@tboerger Don't get me wrong. I got to like the e-mail thing because now I read all my GitHub stuff from e-mail. But for someone who doesn't it be annoying. I had a lot of "ah, let me quickly check this issue in my email and look at it further tonight" and then I ended up not finding the issue and ploughing through archived e-mails to find it back :D

[stroucki]

My team would like commit messages, so I'm working on implementing that for all watchers to a repository.

There is a "notifyWatchers" function on commit, but all it does is make an entry in a database table.

[stroucki]

My team would like commit messages, so I'm working on implementing that for all watchers to a repository.

There is a "notifyWatchers" function on commit, but all it does is make an entry in a database table.

[andreynering]

@stroucki Did you start anything?

I just started but only had time to create the database table until you sent this message. 😃

Maybe we should create a feature branch and work together on this, so we don't have conflicting changes.

[andreynering]

@stroucki Did you start anything?

I just started but only had time to create the database table until you sent this message. 😃

Maybe we should create a feature branch and work together on this, so we don't have conflicting changes.

[stroucki]

@andreynering Actually I have something that works :)

Though it is probably not acceptable for general usage, since you can't opt out. It is similar to what gogs does for mentionemails: Do a database entry that apparently is only useful for webhooks, then send out email to all watchers.

You can see it in my fork: (note I am still based on gogs)
https://github.com/stroucki/gogs/tree/commitemails

But while testing I see that it is not working for commits made via ssh yet.

[stroucki]

@andreynering Actually I have something that works :)

Though it is probably not acceptable for general usage, since you can't opt out. It is similar to what gogs does for mentionemails: Do a database entry that apparently is only useful for webhooks, then send out email to all watchers.

You can see it in my fork: (note I am still based on gogs)
https://github.com/stroucki/gogs/tree/commitemails

But while testing I see that it is not working for commits made via ssh yet.

[andreynering]

@stroucki Thanks for linking your branch.

I started something on #321 (still in an early stage) for who's interested.

We will probably integrate notifications and email sending. Your patch will be useful.

[andreynering]

@stroucki Thanks for linking your branch.

I started something on #321 (still in an early stage) for who's interested.

We will probably integrate notifications and email sending. Your patch will be useful.

[stroucki]

I've been looking at getting notifications working on ssh commits today.
This is pretty messy, because 1) the serve command doesn't set up any of the mailer stuff and 2) it uses "log.GitLogger" to log stuff, but the mailer initialization bits want to log, they use "log". Things don't even seem to blow up then, the git-receive-pack ends up hanging and nothing really happens.
I got to the point now where it is sending commit messages, but the command line output gets a "failed to push some refs" error (but things have committed).

[stroucki]

I've been looking at getting notifications working on ssh commits today.
This is pretty messy, because 1) the serve command doesn't set up any of the mailer stuff and 2) it uses "log.GitLogger" to log stuff, but the mailer initialization bits want to log, they use "log". Things don't even seem to blow up then, the git-receive-pack ends up hanging and nothing really happens.
I got to the point now where it is sending commit messages, but the command line output gets a "failed to push some refs" error (but things have committed).

[stroucki]

OK. I think I have it. I now get commit messages on https and ssh commits.

The big thing was that console logs interfere with the git processes that gogs creates. I'm guessing that since the log used stdout, the subprocess never terminated. Besides that, mailing services needed to be initialized too.
It is too late for tonight, but tomorrow I'll update my branch.

[stroucki]

OK. I think I have it. I now get commit messages on https and ssh commits.

The big thing was that console logs interfere with the git processes that gogs creates. I'm guessing that since the log used stdout, the subprocess never terminated. Besides that, mailing services needed to be initialized too.
It is too late for tonight, but tomorrow I'll update my branch.

[bkcsoft]

@andreynering I also think that Action-table holds most of the data already. Might be worth looking into before making a new table 🙂

[bkcsoft]

@andreynering I also think that Action-table holds most of the data already. Might be worth looking into before making a new table 🙂

[lunny]

^

[lunny]

^

[andreynering]

@bkcsoft @lunny I will take a look at that, but I think we need another table. An action is created every time an issue changes, but we should have only one notification per issue/PR.

Also, an user may be subscribed to an issue but don't watch the repo, so won't have an action for him, etc. Situations like this.

[andreynering]

@bkcsoft @lunny I will take a look at that, but I think we need another table. An action is created every time an issue changes, but we should have only one notification per issue/PR.

Also, an user may be subscribed to an issue but don't watch the repo, so won't have an action for him, etc. Situations like this.

[stroucki]

Is the action table actually used for anything?

[stroucki]

Is the action table actually used for anything?

[stroucki]

I committed changes to my branch that now let commit messages go out to watchers on https and ssh commits.

[stroucki]

I committed changes to my branch that now let commit messages go out to watchers on https and ssh commits.

[andreynering]

@stroucki

Is the action table actually used for anything?

It's only used by the feed on the dashboard.

I committed changes to my branch that now let commit messages go out to watchers on https and ssh commits

I'll look into integrate that after I'm done with my implementation

[andreynering]

@stroucki

Is the action table actually used for anything?

It's only used by the feed on the dashboard.

I committed changes to my branch that now let commit messages go out to watchers on https and ssh commits

I'll look into integrate that after I'm done with my implementation

[bkcsoft]

@lunny this isn't done yet ,only part 1 of 2 ;)

[bkcsoft]

@lunny this isn't done yet ,only part 1 of 2 ;)

[bkcsoft]

ooh, it was #523 that had the text "resolve #number" in it 😆

[bkcsoft]

ooh, it was #523 that had the text "resolve #number" in it 😆

[lunny]

So not me? Or maybe we have to review and change the title when merging it.

[lunny]

So not me? Or maybe we have to review and change the title when merging it.

[bkcsoft]

@lunny no need to change the title, just the body 🙁

[bkcsoft]

@lunny no need to change the title, just the body 🙁

[strk]

Is the roadmap in the original submission updated after part 2 ?
I've tested notifications on try.gitea.io but doesn't seem to be working: https://try.gitea.io/gitea/gitea/issues/1

[strk]

Is the roadmap in the original submission updated after part 2 ?
I've tested notifications on try.gitea.io but doesn't seem to be working: https://try.gitea.io/gitea/gitea/issues/1

[strk]

Step 2, merged, was #539

[strk]

Step 2, merged, was #539

[andreynering]

@strk You are not watching the repo, so you won't get any notifications:

https://try.gitea.io/gitea/gitea/watchers

[andreynering]

@strk You are not watching the repo, so you won't get any notifications:

https://try.gitea.io/gitea/gitea/watchers

[strk]

On Thu, Jan 05, 2017 at 04:39:14PM -0800, Andrey Nering wrote: @strk You are not watching the repo, so you won't get any notifications: https://try.gitea.io/gitea/gitea/watchers

I thought one of the goals of the notification system was allowing for per-issue watchers ?

[strk]

On Thu, Jan 05, 2017 at 04:39:14PM -0800, Andrey Nering wrote: @strk You are not watching the repo, so you won't get any notifications: https://try.gitea.io/gitea/gitea/watchers

I thought one of the goals of the notification system was allowing for per-issue watchers ?

[andreynering]

I thought one of the goals of the notification system was allowing for per-issue watchers?

Yes, but it was not implemented yet. I'm doing it in parts. By now it's only notifying watchers. I hope we get it 100℅ on v1.1.0

[andreynering]

I thought one of the goals of the notification system was allowing for per-issue watchers?

Yes, but it was not implemented yet. I'm doing it in parts. By now it's only notifying watchers. I hope we get it 100℅ on v1.1.0

[gayprogrammer]

I would like to note that email notifications currently do not say which user commented on the issue. It only displays the content of the comment.

Can we add the name of who commented to the email somehow?

[gayprogrammer]

I would like to note that email notifications currently do not say which user commented on the issue. It only displays the content of the comment.

Can we add the name of who commented to the email somehow?

[tboerger]

Than the current mail template is missing that information

[tboerger]

Than the current mail template is missing that information

[mxmehl]

It would be good to have a button to mark all notifications as read. (I hope this is the right issue for this feature request)

[mxmehl]

It would be good to have a button to mark all notifications as read. (I hope this is the right issue for this feature request)

[andreynering]

@mxmehl Yes, that's reasonable.

[andreynering]

@mxmehl Yes, that's reasonable.

[mxmehl]

@mxmehl Yes, that's reasonable.

Cool! Could you please add that to the list in the top post?

[mxmehl]

@mxmehl Yes, that's reasonable.

Cool! Could you please add that to the list in the top post?

[andreynering]

@mxmehl Done!

[andreynering]

@mxmehl Done!

[McLive]

Any update on this? I'd like to see E-Mail notifications for pushes.

gogs/gogs#1441

[McLive]

Any update on this? I'd like to see E-Mail notifications for pushes.

gogs/gogs#1441

[lunny]

@McLive added

[lunny]

@McLive added

[hasufell]

What I find missing here is optional admin notifications, like when a user has registered.

[hasufell]

What I find missing here is optional admin notifications, like when a user has registered.