Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve panic on failed interface conversion in migration v156 (#15604) #15610

Merged

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Apr 24, 2021

go panics otherwise with panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist, thanks to Codeberg/Andi for reporting this.

backport of #15604

…tea#15604)

go panics otherwise with `panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist`, thanks to Codeberg/Andi for reporting this.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@techknowlogick techknowlogick added this to the 1.14.2 milestone Apr 24, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2021
@techknowlogick
Copy link
Member Author

🚀

@techknowlogick techknowlogick merged commit 761111f into go-gitea:release/v1.14 Apr 25, 2021
@techknowlogick techknowlogick deleted the backport-15604-1.14 branch April 25, 2021 15:58
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants