Allow commit status popup on /pulls page

[parnic]

The /pulls page doesn't contain a "repository" element, so the early-out here was preventing the commit status popup hook from working. However, the only thing the .repository element is being used for here is determining whether the popup should be on the right or on the left, so we don't actually need the element to exist for the hook to work.

[parnic]

Pull request #19375 allows the statuses on /pulls pages to appear clickable, but this commit is required to make the popup actually work there, so consider this an amendment to that PR (I would have just added this there, but that PR is already approved and waiting on being merged, so I didn't want to muddy the waters).

[wxiaoguang]

Which template? If the page (template) is repository related, it should have the CSS class repository.

Otherwise the commit-statuses-trigger related code could be extracted into a new dedicated function, instead of mixing them together.

[parnic]

Which template? If the page (template) is repository related, it should have the CSS class repository.

Otherwise the commit-statuses-trigger related code could be extracted into a new dedicated function, instead of mixing them together.

This originates from routers\web\user\home.go's func Pulls(ctx *context.Context) which ultimately ends up rendering user/dashboard/issues. For the Try.Gitea page, that would be https://try.gitea.io/pulls and the org/team-filtered-org version of the same page. No element on this page uses the repository class, but commit statuses can still show up there.

I'm happy to move that function somewhere else if that's more desirable. Does it need a new .js file or where would you prefer it to live?

[wxiaoguang]

I see, I feel that it could be clearer to move the commit-statuses-trigger into a new function.

More details: at the moment, Gitea's JS code are using a simple mechanism to describe the dependency:

function initXxx() {
    if (!$('.xxx').length) return;
}

So if some unrelated code appears before the if (!$('.xxx').length) return;, it would make the dependency unclear and harder to get refactored in future.

[parnic]

I see, I feel that it could be clearer to move the commit-statuses-trigger into a new function.

More details: at the moment, Gitea's JS code are using a simple mechanism to describe the dependency:

function initXxx() {
    if (!$('.xxx').length) return;
}

So if some unrelated code appears before the if (!$('.xxx').length) return;, it would make the dependency unclear and harder to get refactored in future.

Understood - that makes sense. I'll make that change.

[parnic]

@wxiaoguang pushed those changes.

[6543]

🪨