Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docs.gitea.com instead of docs.gitea.io #26739

Merged
merged 3 commits into from
Aug 27, 2023
Merged

Use docs.gitea.com instead of docs.gitea.io #26739

merged 3 commits into from
Aug 27, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 26, 2023

No description provided.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Aug 26, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 26, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 26, 2023
@lunny lunny added the backport/v1.20 This PR should be backported to Gitea 1.20 label Aug 26, 2023
@silverwind
Copy link
Member

Those 5 cases in translation should ideally be moved to printf solutions so the URL can be moved out.

@lunny
Copy link
Member Author

lunny commented Aug 26, 2023

Those 5 cases in translation should ideally be moved to printf solutions so the URL can be moved out.

I just leave those to other PRs because there maybe different idea about how to move the URL out of translation.

@puni9869
Copy link
Member

@lunny where we can see the dev version of docs, can we deploy it to dev environment. I want to give a try to this change.

@lunny
Copy link
Member Author

lunny commented Aug 26, 2023

@lunny where we can see the dev version of docs, can we deploy it to dev environment. I want to give a try to this change.

It's a good question, I think it's impossible currently to do that. Maybe a PR could copy some scripts from https://gitea.com/gitea/gitea-docusaurus

@puni9869
Copy link
Member

@lunny where we can see the dev version of docs, can we deploy it to dev environment. I want to give a try to this change.

It's a good question, I think it's impossible currently to do that. Maybe a PR could copy some scripts from https://gitea.com/gitea/gitea-docusaurus

Thanks, thats what I want.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 27, 2023
@silverwind
Copy link
Member

silverwind commented Aug 27, 2023 •
edited
Loading

@lunny where we can see the dev version of docs, can we deploy it to dev environment. I want to give a try to this change.

It's a good question, I think it's impossible currently to do that. Maybe a PR could copy some scripts from https://gitea.com/gitea/gitea-docusaurus

Maybe we can have a make docs-preview that clones the docasaurus repo into a subdirectory, builds it in dev mode with live reload and then hosts it on a local port (3001?).

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 27, 2023
@puni9869
Copy link
Member

puni9869 commented Aug 27, 2023 •
edited
Loading

@lunny where we can see the dev version of docs, can we deploy it to dev environment. I want to give a try to this change.

It's a good question, I think it's impossible currently to do that. Maybe a PR could copy some scripts from https://gitea.com/gitea/gitea-docusaurus

Maybe we can have a make docs-preview that clones the docasaurus repo into a subdirectory, builds it in dev mode with live reload and then hosts it on a local port (3001?).

That will work too

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 27, 2023
@lunny lunny enabled auto-merge (squash) August 27, 2023 11:30
@lunny lunny merged commit 476b9d1 into go-gitea:main Aug 27, 2023
24 checks passed
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.20. @lunny, please send one manually. 🍵

go run ./contrib/backport 26739
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 27, 2023
@lunny lunny deleted the lunny/update_docs_links branch August 28, 2023 00:58
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 28, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bc79ffa 
* giteaofficial/main:
  Fix bug for ctx usage (go-gitea#26762)
  Remove some transition related code (go-gitea#26755)
  Expanded minimum RSA Keylength to 3072 (go-gitea#26604)
  [skip ci] Updated licenses and gitignores
  Use docs.gitea.com instead of docs.gitea.io (go-gitea#26739)
  Adding hint `Archived` to archive label. (go-gitea#26741)

# Conflicts:
#	templates/base/head_navbar.tmpl
lunny added a commit to lunny/gitea that referenced this pull request Aug 28, 2023
@lunny
Use docs.gitea.com instead of docs.gitea.io (go-gitea#26739)
569694c
@lunny lunny mentioned this pull request Aug 28, 2023
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Aug 28, 2023
lunny added a commit that referenced this pull request Aug 28, 2023
@lunny
Use docs.gitea.com instead of docs.gitea.io (#26769)
b159ebb 
backport #26739
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@puni9869 puni9869 puni9869 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @silverwind @puni9869 @GiteaBot