Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix commit page showing status for current default branch (#5649) #5650

Merged
merged 1 commit into from Jan 6, 2019
Merged

fix commit page showing status for current default branch (#5649) #5650

merged 1 commit into from Jan 6, 2019

Conversation

apricote
Copy link
Contributor

@apricote apricote commented Jan 6, 2019

Fixes #5649.

Instead of showing the status for the current commit in the default branch (ctx.Repo.Commit.ID) show status for selected commit (commitID).

@apricote
fix commit page showing status for current default branch
2627273 
Signed-off-by: Julian Tölle <julian.toelle97@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #5650 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5650      +/-   ##
=========================================
- Coverage   37.81%   37.8%   -0.01%     
=========================================
  Files         322     322              
  Lines       47489   47489              
=========================================
- Hits        17957   17955       -2     
- Misses      26943   26946       +3     
+ Partials     2589    2588       -1
Impacted Files Coverage Δ
routers/repo/commit.go 16.26% <0%> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0236856...2627273. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2019
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 6, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 6, 2019
@lafriks lafriks added this to the 1.8.0 milestone Jan 6, 2019
@lafriks lafriks merged commit 97dafdc into go-gitea:master Jan 6, 2019
@lafriks
Copy link
Member

lafriks commented Jan 6, 2019

Please backport to release/1.7 branch

@apricote apricote mentioned this pull request Jan 6, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 6, 2019
jonasfranz pushed a commit that referenced this pull request Jan 6, 2019
@apricote @jonasfranz
fix commit page showing status for current default branch (#5650) (#5653
652e09f 
)

Signed-off-by: Julian Tölle <julian.toelle97@gmail.com>
@filipnavara filipnavara mentioned this pull request Jan 7, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@filipnavara filipnavara filipnavara approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Commit Diff page always shows status for current default branch
7 participants
@apricote @codecov-io @lafriks @filipnavara @zeripath @techknowlogick @bkcsoft