New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Update discussion #5937

Open
techknowlogick opened this Issue Feb 2, 2019 · 5 comments

Comments

6 participants
@techknowlogick
Copy link
Member

techknowlogick commented Feb 2, 2019

Per discussion in #5932, and @kolaente's suggestion. I am opening this ticket so we can discuss future of Gitea UI

@sondr3

This comment has been minimized.

Copy link
Contributor

sondr3 commented Feb 3, 2019

I would love to see this happen as Gitea isn't very usable on mobile devices, but this would be a massive undertaking and one that I hope would not take away all the developers from maintaining and working on regular features for Gitea. 😃

@silverwind

This comment has been minimized.

Copy link
Contributor

silverwind commented Feb 3, 2019

Focusing only on CSS now, I have two primary concerns:

  1. semantic-ui is a dead end technology-wise. It does not embrace flexbox and I generally think it's doing to much on its own. I'd prefer to be in a bit more control, maybe just by adding some helper classes.

  2. less is probably not needed. I think selector nesting is a bad because it leads to uselessly long selectors that are hard to search for in the source. With CSS supporting variables, I don't really see much use in having a preprocessor. I'd suggest converting to plain CSS.

@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented Feb 3, 2019

Dropping less in favour of native css variables would mean dropping support for some browsers, but I guess I'd be okay with that since most of the people using Gitea are devs anyways who usually are using up to date browsers.
A bigger problem for me would be to not be able to use things like darken($color) and being able to split the css in multiple files which would then be combined into one single css (I know native css can do that too... kind of)

A new design might also help to make it more clear Gitea is much different from Gogs because as of now, both share pretty much the same ui.

Framkework-wise, I'd throw bulma.io in the mix as that is something I've used in the past and found it pretty good. I takes the hassle out of most things while still allowing high custimization and therefore easy theming.

@tankerkiller125

This comment has been minimized.

Copy link

tankerkiller125 commented Feb 5, 2019

I think that giving Gitea its own unique UI is something that would certainly help show the difference between it and Gogs, At the same time I have to say that less or scss is probably something that should continue to exist in this project as some of their functionality is not available in CSS, framework wise I have no opinion that would benefit this discussion since I personally just use Bootstrap 4 for my projects (not something that should be used here)

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Feb 5, 2019

Bulma sounds good to me :) thought it means full UI rewrite sadly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment