Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statuses API only shows first 10 statuses #7136

Closed
2 of 7 tasks
dr-consit opened this issue Jun 5, 2019 · 2 comments · Fixed by #7141
Closed
2 of 7 tasks

Statuses API only shows first 10 statuses #7136

dr-consit opened this issue Jun 5, 2019 · 2 comments · Fixed by #7141
Labels
type/enhancement An improvement of existing functionality

Comments

@dr-consit
Copy link

Description

I have created much more than 10 statuses on the linked commit above. Yet the statuses API only shows the first 10. If it must be limited to 10, I believe it should at least be the 10 most recent.
zeripath added a commit to zeripath/gitea that referenced this issue Jun 5, 2019
@zeripath
Fix go-gitea#7136: Add paging and extend API GetCommitStatuses
d2b4f75
@lunny
Copy link
Member

lunny commented Jun 6, 2019

should be closed by #7141

@zeripath
Copy link
Contributor

zeripath commented Jun 6, 2019

#7141 does fix this - but it's not perfect the API returns a bare []api.Status with no space to say how many statuses there are - so you just have to page until you reach the end.

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 10, 2019
@zeripath zeripath mentioned this issue Jul 8, 2019
Merged
zeripath added a commit that referenced this issue Jul 25, 2019
@zeripath
Fix #7136: Add paging and extend API GetCommitStatuses (#7141)
734aa96 
* Fix #7136: Add paging and extend API GetCommitStatuses

* update swagger

* Update routers/api/v1/repo/status.go

Co-Authored-By: techknowlogick <matti@mdranta.net>

* Update routers/api/v1/repo/status.go

Co-Authored-By: techknowlogick <matti@mdranta.net>

* Update routers/api/v1/repo/status.go

Co-Authored-By: techknowlogick <matti@mdranta.net>

* Apply suggestions from code review
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7136: Add paging and extend API GetCommitStatuses zeripath/gitea
3 participants
@lunny @zeripath @dr-consit