Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: feature request to add author/committer date #9462

Closed
lukastribus opened this issue Dec 22, 2019 · 4 comments · Fixed by #9464
Closed

API: feature request to add author/committer date #9462

lukastribus opened this issue Dec 22, 2019 · 4 comments · Fixed by #9464

Comments

@lukastribus
Copy link

@lukastribus lukastribus commented Dec 22, 2019

  • Gitea version (or commit ref): 1.11.0+dev-481-g1df701fd1
  • Git version: 2.17.1 or whatever try.gitea.io runs
  • Operating system: Ubuntu 16.04 or whatever try.gitea.io runs
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes
    • No
    • Not relevant
  • Log gist: n/a

Description

This is a feature request for the API allowing to add/update/delete files (and commit it):
​/repos​/{owner}​/{repo}​/contents​/{filepath}

I would like to be able to specify the author date and commit date, just as git commit on the command line allows (--date argument or GIT_AUTHOR_DATE and GIT_COMMITTER_DATE environment variable).

We should also allow the same date formats that git commit itself allows, so not only a single unix timestamp, but also the time zone offset (or even RFC 2822/ISO8601), so that we can actually use local time zones as opposed to only UTC.

Extending the API with optional parameters does not break backwards compatibility, so this should be fine.

CCing @6543 who recently touched this code.

What do you think about this request? Would this change be complex?

@6543

This comment has been minimized.

Copy link
Member

@6543 6543 commented Dec 22, 2019

first look: I would extend the body, more exact:
from ...

  • DeleteFileOptions
  • CreateFileOptions
  • UpdateFileOptions
    ... the Identity type has to be extendet ...
@6543

This comment has been minimized.

Copy link
Member

@6543 6543 commented Dec 22, 2019

but extending IdentityOptions and Identity with a fild not related to itself is ... mad

@6543

This comment has been minimized.

Copy link
Member

@6543 6543 commented Dec 22, 2019

what do you thin of:

{
  "message": "my commit message",
  "committer": {
    "name": "Monalisa Octocat",
    "email": "octocat@github.com"
  },
  "content": "bXkgbmV3IGZpbGUgY29udGVudHM=",
  ...
  "dates": {
    "author": "2014-11-07T22:01:45Z",
    "committer": "2014-11-07T22:01:45Z"
  },
  ...
}
@6543 6543 mentioned this issue Dec 22, 2019
2 of 2 tasks complete
@lunny lunny closed this in #9464 Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.