Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never allow an empty password to validate (#9682) #9684

Merged
merged 2 commits into from Jan 11, 2020
Merged

Never allow an empty password to validate (#9682) #9684

merged 2 commits into from Jan 11, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 9, 2020

No description provided.

@zeripath zeripath added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Jan 9, 2020
@zeripath zeripath added this to the 1.10.3 milestone Jan 9, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2020
zeripath
zeripath commented Jan 11, 2020
View reviewed changes
models/user.go Outdated Show resolved Hide resolved
@lafriks lafriks merged commit 0e5126d into go-gitea:release/v1.10 Jan 11, 2020
@zeripath zeripath deleted the backport-9682-1.10 branch January 11, 2020 11:30
@lunny lunny added topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! and removed issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Jan 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.10.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zeripath @lafriks @guillep2k @6543 @lunny @GiteaBot